-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix capacity issue for category aware #16391
base: master
Are you sure you want to change the base?
Conversation
indexing-service/src/main/java/org/apache/druid/indexing/overlord/CategoryCapacityInfo.java
Fixed
Show resolved
Hide resolved
@AlbericByte , thanks for the changes. Please add an explanation of the approach you have taken in the PR description and also include a release note for the new API changes. |
@kfaraz i added the explanation and updated the release note section. for release note section, it is my first time, i am not sure it is correct format, if not, could you help to share the right format, i will update asap. And I will fix the test |
@kfaraz @abhishekagarwal87 and @gianm
|
hi @kfaraz @abhishekagarwal87 and @gianm |
This pull request has been marked as stale due to 60 days of inactivity. |
unstale |
This pull request has been marked as stale due to 60 days of inactivity. |
unstale |
This pull request has been marked as stale due to 60 days of inactivity. |
unstale |
This pull request has been marked as stale due to 60 days of inactivity. |
Fixes #15847.
Description
Fix the bug of capacity api which is not category aware
The proposal solution is following:
Summary: according to the WorkerSelectStrategy(category based or not), set the category capacity in TotalWorkerCapacityResponse, in client side, compare the category capacity and totalWorkerCapacity * taskSlotRatio, take the smaller one
Fixed the bug 15847
Release note
Fix the bug of getCompactionTaskCapacity which is not category aware
Update the getTotalWorkerCapacity of OverlordResource
if WorkerSelectStrategy is category based strategy(FillCapacityWithCategorySpecWorkerSelectStrategy and EqualDistributionWithCategorySpecWorkerSelectStrategy), TotalWorkerCapacityResponse will contains the capacity group by category.
Key changed/added classes in this PR
CategoryCapacityInfo
OverlordResource
TotalWorkerCapacityResponse
EqualDistributionWithCategorySpecWorkerSelectStrategy
FillCapacityWithCategorySpecWorkerSelectStrategy
WorkerSelectStrategy
WorkerSelectUtils
OverlordResourceTest
EqualDistributionWithCategorySpecWorkerSelectStrategyTest
FillCapacityWithCategorySpecWorkerSelectStrategyTest
IndexingCategoryCapacityInfo
IndexingTotalWorkerCapacityInfo
IndexingWorker
CompactSegments
CoordinatorDutyUtils
KillUnusedSegments
OverlordClientImplTest
CompactSegmentsTest
KillUnusedSegmentsTest
This PR has: