Update default value of useMaxMemoryEstimates for Hadoop jobs #16280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area - Batch Ingestion
Area - Segment Format and Ser/De
labels
kgyrtkirk
reviewed
Apr 25, 2024
indexing-hadoop/src/main/java/org/apache/druid/indexer/HadoopTuningConfig.java
Outdated
Show resolved
Hide resolved
indexing-hadoop/src/main/java/org/apache/druid/indexer/HadoopTuningConfig.java
Outdated
Show resolved
Hide resolved
indexing-hadoop/src/main/java/org/apache/druid/indexer/HadoopTuningConfig.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Zoltan Haindrich <kirk@rxd.hu>
|
Thanks for catching the missing parameter, @kgyrtkirk ! |
kgyrtkirk
approved these changes
Apr 25, 2024
|
i wonder if there is actually much risk for hadoop or if we can remove this parameter even sooner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
useMaxMemoryEstimatesparameter was introduced as a way to switch between old and new methods of estimating memory footprint while building anOnHeapIncrementalIndex. The default value of this parameter has beenfalse(i.e. use newer more accurate estimates) for several Druid releases now, and has been found to be very stable.The changes in this PR are meant to align the usage of this parameter in Hadoop ingestion with native ingestion. Eventually, the parameter
useMaxMemoryEstimateswill be completely removed from Druid.Changes
useMaxMemoryEstimatesfalseto align with current native batch ingestion