Handling nil selector column in vector math processors #16128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else if (inputType.is(ExprType.DOUBLE)) { | ||
| processor = doubleOutDoubleInSupplier.get(); | ||
| } | ||
| if (inputType == null || inputType.is(ExprType.DOUBLE)) { |
There was a problem hiding this comment.
nit: use Types.isNullOr(inputType, ExprType.DOUBLE), same for other lines
| return inspector.areNumeric(args) && inspector.canVectorize(args); | ||
| final ExpressionType outputType = args.get(0).getOutputType(inspector); | ||
| if (outputType == null && NullHandling.replaceWithDefault()) { | ||
| return false; |
There was a problem hiding this comment.
worth leaving a comment about why this is the case. something about how non-vectorized treats null values as STRING types, which makes it kind of complicated to achieve consistent behavior for vector and non-vector engines
adarshsanjeev
approved these changes
Apr 2, 2024
clintropolis
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently If a segment does not have a column, then an math expression processor triggered on that segment involving that column is resulting in a
Unable to vectorize expressionexception.This PR aims to fix these by defaulting the input type to double type.
Key changed/added classes in this PR
VectorMathProcessorsFunctionVectorExprSanityTestThis PR has: