[Backport] Only use ExprEval in ConstantExpr if its known that it will be safe (#15694) #16100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pache#15694) * which creates a singleThreaded version of the actual expression (caching ExprEval is allowed) * to make a whole subtree of expressions 'singleThreaded' - uses to create the new expression tree * creates a specialized which does cache the * some annotations were added to make it more likely to notice that there might be something off if a similar change will be made around here for some reason (cherry picked from commit 27d7c30)
LakshSingla
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only use ExprEval in ConstantExpr if its known that it will be safe (#15694)
(cherry picked from commit 27d7c30)