Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add security ITs to the revised integration tests #15885

Merged
merged 5 commits into from
Feb 20, 2024
Merged

Add security ITs to the revised integration tests #15885

merged 5 commits into from
Feb 20, 2024

Conversation

adarshsanjeev
Copy link
Contributor

@adarshsanjeev adarshsanjeev commented Feb 12, 2024 •
edited
Loading

  • Add a new category of revised ITs for authorization.
  • Adds tests for authentication and authorization to revised ITs.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@adarshsanjeev adarshsanjeev marked this pull request as ready for review February 12, 2024 14:49
findingrish
findingrish reviewed Feb 16, 2024
View reviewed changes
Copy link
Contributor

@findingrish findingrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Minor comments.

integration-tests-ex/cases/src/test/java/org/apache/druid/testsEx/config/Initializer.java Outdated
@@ -187,6 +190,14 @@ public HttpClient getHttpClient(
return delegate;
}

@Provides
@AdminClient
public HttpClient getAdminClientClient(@Client HttpClient delegate)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Should the method name be getAdminClient?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

...gration-tests-ex/cases/src/test/java/org/apache/druid/testsEx/auth/ITSecurityBasicQuery.java
}

@Test
public void testExportWithoutPermissions() throws IOException, ExecutionException, InterruptedException
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add a positive test case as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a test

@cryptoe cryptoe merged commit 9eaaeb5 into apache:master Feb 20, 2024
83 checks passed
@adarshsanjeev adarshsanjeev added this to the 30.0.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findingrish findingrish findingrish left review comments

@cryptoe cryptoe cryptoe approved these changes

Assignees
No one assigned
Labels
Area - Testing
Projects
None yet
Milestone
30.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@adarshsanjeev @cryptoe @findingrish @asdf2014