Fix possibly thread unsafe constants #15743
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianm
reviewed
Feb 6, 2024
| abstract class ConstantExpr<T> implements Expr | ||
| { | ||
| final ExpressionType outputType; | ||
|
|
||
| @SuppressWarnings("Immutable") |
There was a problem hiding this comment.
What does @Immutable do and why are these various @SuppressWarnings("Immutable") necessary (here, in BaseTypeSignature, in ColumnCapabilitiesImpl)?
I am not familiar with this annotation so was just wondering what the extra lines are for.
There was a problem hiding this comment.
- the
@Immutableenables a compile time check that the class satisfies some immutable rules- such a check could have warned me before doing the original PR
- the suppression is added for this field as we don't know what it is...but since this class will handle it as a blackbox I think its okay to ignore it
- I had to also add
SuppressWarnings("Immutable")toColumnCapabiliiesImplbecause its kinda immutable; but fixing that turned into a massacre - I've asked @clintropolis about the value of such a change and based on that conversion I opted to not touch a lot of files without much benefits
should I remove these @Immutable related changes?
There was a problem hiding this comment.
Ah, it's an errorprone thing? Cool. I was just wondering. I don't think we should necessarily aggressively use it everywhere (we have a lot of immutable classes, seems like it would be a lot of annotation noise) but it seems useful here.
|
closing as #15694 was merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is an alternate version to retain some positive changes #15552 ; but fix the thread safety issue
ExprEval-s fromConstantExprclasses@Immutablemarkers