update timeseries to reflect NULL filling #15512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintropolis
reviewed
Dec 7, 2023
docs/querying/timeseriesquery.md
Outdated
| upon the grand total aggregations. | ||
|
|
||
| ## Zero-filling | ||
| ## NULL filling |
Member
There was a problem hiding this comment.
I wonder if we should call this "Empty filling" or "Empty bucket filling" or something similar?
It doesn't actually always fill with zeros or nulls depending on the mode, rather it fills with the default values of the aggregator functions. Since they aggregate no rows, only the default value is there. https://github.com/apache/druid/blob/master/docs/querying/sql-aggregations.md has the default values of the aggregators.
docs/querying/timeseriesquery.md
Outdated
| ## NULL filling | ||
|
|
||
| Timeseries queries normally fill empty interior time buckets with zeroes. For example, if you issue a "day" granularity | ||
| By default timeseries queries fill empty interior time buckets with NULL. |
Member
There was a problem hiding this comment.
same comment about default aggregator value(s), and in other places too.
clintropolis
approved these changes
Dec 7, 2023
techdocsmith
commented
Dec 7, 2023
vtlim
reviewed
Dec 7, 2023
vtlim
reviewed
Dec 7, 2023
techdocsmith
commented
Dec 7, 2023
vtlim
approved these changes
Dec 7, 2023
techdocsmith
added a commit
to techdocsmith/druid
that referenced
this pull request
Dec 13, 2023
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
9 tasks
317brian
added a commit
that referenced
this pull request
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates timeseries docs to reflect the impact of
druid.generic.useDefaultValueForNull=falseThis PR has: