DRILL-5523: Revert if condition in UnionAllRecordBatch changed in DRI…#842
Closed
arina-ielchiieva wants to merge 1 commit intoapache:masterfrom
Closed
DRILL-5523: Revert if condition in UnionAllRecordBatch changed in DRI…#842arina-ielchiieva wants to merge 1 commit intoapache:masterfrom
arina-ielchiieva wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
@vvysotskyi since you are working on DRILL-4824, please review pull request and confirm that issue will be fixed after DRILL-4824 is merged. |
vvysotskyi
approved these changes
May 18, 2017
Member
vvysotskyi
left a comment
vvysotskyi
left a comment
There was a problem hiding this comment.
Yes, when DRILL-4824 is merged, this issue will be fixed. +1
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…LL-5419
If condition in UnionAllRecordBatch which was changed to correct one in DRILL-5419 but this change caused the regression (DRILL-5521).
The root cause is not in change itself but rather in missing indication of child column in map types when it is null. There is a big project upcoming re-working json reader implementation, including map types (DRILL-4824) which will fix the problem.
So far reverting change to initial state so users won't see the regression till DRILL-4824 is merged.