Skip to content

Conversation

@jaltekruse
Copy link
Contributor

…rage plugin configuration

@jaltekruse
Copy link
Contributor Author

@sudheeshkatkam @jacques-n Can you please review?

@jaltekruse
Copy link
Contributor Author

@sudheeshkatkam Just saw that you actually had a patch for this, I was looking at DRILL-2663 originally, and found the duplicate DRILL-2653 when I went to write the commit message. I think I'll merge this version because it is a little clearer for users in the case of repeated failures, but I didn't mean to ignore your patch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This alert will show even if the update succeeds, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally I didn't have the "Please retry:" I had added that after finding your patch. Previously, it would just show either the error or the success message and only in the case of the success message reload. Will push a fix

@sudheeshkatkam
Copy link
Contributor

That's fine, Jason :)

@jaltekruse
Copy link
Contributor Author

@sudheeshkatkam Message fixed, also added more colors :)

@sudheeshkatkam
Copy link
Contributor

+1

@asfgit asfgit closed this in 9fa7b28 Jan 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants