DRILL-4291: Fix Missing classes when trying to query varchar[] using jdbc-all #336
Conversation
jacques-n
commented
Jan 24, 2016
jacques-n
commented
- Create a new simplified version of the Hadoop Text class that doesn't include massive dependencies.
- Update Vectors to use new Text class.
- Update the jdbc-all module to have a test which also includes complex types.
- Clean up exclusions in Jdbc jar file to reduce file size.
- Add an enforcer rule that ensures the adbc-all jar exclusions are maintained in the future.
There was a problem hiding this comment.
Because a few real changes were made to this class (it isn't just copying the source to avoid including the jar that contains it) it would be good to have an explicit pointer to the version of this class that this was based on. Is this pulled out of the Hadoop source at the commit tagged for the 2.7.1 release?
It might have been cleaner to do this in two commits, one just checking in the class exactly as it appears in Hadoop, with just the packaged changed and a follow up commit the with refactoring to remove the dependencies imported in the hadoop version of the class. At least a mention of a commit ID this was pulled out of would give a pointer to the exact version this was based on if we ever had to apply a patch from Hadoop mainline that didn't merge cleanly.
There was a problem hiding this comment.
I took this from the source jar of the Hadoop 2.7.1 release, not a particular commit. That is why I noted that origin in the comment at the top of the file. Looking at how Hadoop tags, that looks it is the same as ac0538aac347bfd97cc0dee1db49db503c15f1d9 but I think the version number should suffice. Good idea on the two commits. I'll do that in the future if I need to do this kind of thing again.
|
+1 |
…JDBC - Create a new simplified version of the Hadoop Text class that doesn't include massive dependencies. - Update Vectors to use new Text class. - Update the jdbc-all module to have a test which also includes complex types. - Clean up exclusions in Jdbc jar file to reduce file size. - Add an enforcer rule that ensures the adbc-all jar exclusions are maintained in the future.
2 participants
