DRILL-4257: Fix StoragePluginRegistry clean-up behavior #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n up. - Create the storage plugin registry using a Drill configuration parameter to be able to replace the registry implementation. - Change StoragePluginRegistry into an interface and move the implementation to an impl class. - Write documentation for StoragePluginRegistry. - Make StoragePluginRegistry and StoragePluginMap AutoCloseable and ensure that Drillbit closes registry. - Misc Drillbit code reorganization so that fields are at top of class (and static methods at bottom). - Update DrillConfig to support reflection-based creation of storage plugin objects - Remove final from DrillConfig so that application developers can extend config object.
Contributor
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix StoragePluginRegistry clean-up behavior and misc clean up.