Drill 4236: ExternalSort should use the new allocator functionality to better manage it's memory usage #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
+1 LGTM |
Contributor
Author
|
Thanks @StevenMPhillips , I will squash the commits, run one final round of tests and commit to master |
Contributor
There was a problem hiding this comment.
Doesn't the Userexception.memoryError() already have this functionality?
Contributor
Author
There was a problem hiding this comment.
what functionality ?
Contributor
There was a problem hiding this comment.
The string format construction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@StevenMPhillips can you please review ?