-
Notifications
You must be signed in to change notification settings - Fork 986
DRILL-8528: HBase Limit Push Down #3000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
50da524 to
b698849
Compare
cgivre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shfshihuafeng
Thanks for this. I have a few minor nits but other than that it looks good.
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseGroupScan.java
Outdated
Show resolved
Hide resolved
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseGroupScan.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @JsonIgnore | ||
| public int getMaxRecords() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again is there a reason for the JsonIgnore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is a necessary parameter to display in JSON, Do you suggest removing the annotation?
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java
Outdated
Show resolved
Hide resolved
b698849 to
4641849
Compare
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like I spoke too soon. The tests are failing for Java 17.
|
@cgivre The error is not caused by submitted code (hbase limit push down). I added my unit test cases to the original code( there is no hbase limit push down function). The plan shows that the limit has not been pushed down. but it still reports the same error which occurs occasionally.
|
@cgivre Maybe it would be best to open a new JIRA for this error and add some unit test for offset |
I'm going to rerun the failing tests and see if that fixes it. Sometimes these tests are flaky and will randomly fail. |
e6ddeac to
77965e7
Compare
cgivre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1. Thanks for submitting!


DRILL-8528: HBase Limit Push Down
Description
support Limit Push Down for HBase.i test
select * from clicks limit 3
The log shows that The storage layer hbase (HBaseRecordReader)only got 3 rows of data
2025-07-11 01:48:17,297 [178f302e-26db-37dd-500d-db2797b17a5c:frag:0:0] INFO o.a.d.e.s.hbase.HBaseRecordReader - Took 7 ms to get 3 recordsplan is as follow
Documentation
(Please describe user-visible changes similar to what should appear in the Drill documentation.)
Testing
add test: org.apache.drill.hbase.TestHBaseFilterPushDown#testLimitPushDown