[Bug] fix bugs of analyzation of rewrited SQL when triggered the materialized vew #9877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sql having a table alias
EmmyMiao87
added
area/materialized-view
morningman
reviewed
Jun 1, 2022
| TableName tableName = queryColumnSlotRef.getTableName(); | ||
| Preconditions.checkNotNull(tableName); | ||
| SlotRef mvSlotRef = new SlotRef(tableName, mvColumn.getName()); | ||
| SlotRef mvSlotRef = new SlotRef(null, mvColumn.getName()); |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
morningman
reviewed
Jun 2, 2022
github-actions
bot
added
kind/test
and removed
approved
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
github-actions
bot
removed
the
approved
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
morningman
approved these changes
Jun 2, 2022
morningman
pushed a commit
that referenced
this pull request
Jun 2, 2022
morningman
added
dev/merged-1.0.1-deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: #9876
Problem Summary:
Remove the redundant logic of set tableName for the new create slotRef based on the rewrited materialized view column which could cause the unexpected analyze exception
Checklist(Required)