Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](profile) Short-circuit and del predicate filter rows are not counted on vectorized exec #9268

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

zenoyang
Copy link
Member

Proposed changes

  • Short-circuit and del predicate filter rows are not counted on vectorized exec

Problem Summary:

Describe the overview of changes.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the kind/docs Categorizes issue or PR as related to documentation. label Apr 27, 2022
@@ -239,7 +239,7 @@ class Field;
class WrapperField;
using KeyRange = std::pair<WrapperField*, WrapperField*>;

static const int GENERAL_DEBUG_COUNT = 4;
static const int GENERAL_DEBUG_COUNT = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change it to 0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general_debug_ns is used for debugging, by default, there is no place to call it. Therefore, GENERAL_DEBUG_COUNT is set to 0, reducing unnecessary overhead.
When developers need to debug, they can change it according to their own needs.

Copy link
Contributor

@wangbo wangbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangbo wangbo added the area/storage Issues or PRs related to storage engine label Apr 28, 2022
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 28, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei added the dev/backlog waiting to be merged in future dev branch label Apr 29, 2022
@yiguolei yiguolei merged commit 2fa1911 into apache:master Apr 29, 2022
@morningman morningman added dev/1.0.1-deprecated should be merged into dev-1.0.1 branch dev/merged-1.0.1-deprecated PR has been merged into dev-1.0.1 and removed dev/backlog waiting to be merged in future dev branch dev/1.0.1-deprecated should be merged into dev-1.0.1 branch labels Apr 30, 2022
morningman pushed a commit that referenced this pull request May 6, 2022
Kikyou1997 pushed a commit to Kikyou1997/incubator-doris that referenced this pull request May 9, 2022
starocean999 pushed a commit to starocean999/incubator-doris that referenced this pull request May 19, 2022
englefly pushed a commit to englefly/incubator-doris that referenced this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/storage Issues or PRs related to storage engine dev/merged-1.0.1-deprecated PR has been merged into dev-1.0.1 kind/docs Categorizes issue or PR as related to documentation. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants