-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](profile) Short-circuit and del predicate filter rows are not counted on vectorized exec #9268
Conversation
…unted on vectorized exec
@@ -239,7 +239,7 @@ class Field; | |||
class WrapperField; | |||
using KeyRange = std::pair<WrapperField*, WrapperField*>; | |||
|
|||
static const int GENERAL_DEBUG_COUNT = 4; | |||
static const int GENERAL_DEBUG_COUNT = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change it to 0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
general_debug_ns
is used for debugging, by default, there is no place to call it. Therefore, GENERAL_DEBUG_COUNT
is set to 0, reducing unnecessary overhead.
When developers need to debug, they can change it according to their own needs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
…unted on vectorized exec (#9268)
…unted on vectorized exec (apache#9268)
…unted on vectorized exec (apache#9268)
…unted on vectorized exec (apache#9268)
Proposed changes
Problem Summary:
Describe the overview of changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...