Add Elasticsearch scan reader #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imay
reviewed
Mar 25, 2019
be/src/util/es_scroll_parser.h
Outdated
| std::string get_scroll_id(); | ||
| bool count(); | ||
| uint32_t total(); | ||
| Status parse(std::string scroll_result); |
There was a problem hiding this comment.
Suggested change
| Status parse(std::string scroll_result); | |
| Status parse(const std::string& scroll_result); |
be/src/util/es_scroll_query.cpp
Outdated
|
|
||
| } | ||
|
|
||
| std::string ESScrollQueryBuilder::build_next_scroll_body(std::string scroll_id, std::string scroll) { |
There was a problem hiding this comment.
Suggested change
| std::string ESScrollQueryBuilder::build_next_scroll_body(std::string scroll_id, std::string scroll) { | |
| std::string ESScrollQueryBuilder::build_next_scroll_body(const std::string& scroll_id, const std::string& scroll) { |
lide-reed
pushed a commit
that referenced
this pull request
Apr 8, 2019
lide-reed
pushed a commit
that referenced
this pull request
Apr 15, 2019
lide-reed
pushed a commit
that referenced
this pull request
Apr 18, 2019
lide-reed
pushed a commit
to lide-reed/incubator-doris
that referenced
this pull request
Apr 18, 2019
lide-reed
pushed a commit
that referenced
this pull request
Apr 28, 2019
mrhhsg
pushed a commit
to mrhhsg/doris
that referenced
this pull request
Oct 4, 2022
* topn detail query optimization: runtime predicate for rows * add missing new files runtime_predicate.h/cpp * topn detail query opt: runtime predicate for segments and pages * topn detail query opt: fe check query to enable opt * do not use topn opt for order by string type * fix nullpointer when check type * support more types and using TypeIndex in runtime_predicate * [enhance-WIP](topn-two-phase) implement topn two phase read (apache#783) * [fix](topn) fix conjunct_expr_root nullptr (apache#794) * [enhance](topn-two-phase) support VOlapScanNode (apache#799) * [enhance](topn) trick setParallelExecNum(1) when using topn optimization (apache#802) * use HeapSorter when _use_topn_opt or no var length field * remove debug log Co-authored-by: Kang <kxiao.tiger@gmail.com>
liaoxin01
pushed a commit
to liaoxin01/doris
that referenced
this pull request
Nov 18, 2022
* Opt perf topn (apache#805) * topn detail query optimization: runtime predicate for rows * add missing new files runtime_predicate.h/cpp * topn detail query opt: runtime predicate for segments and pages * topn detail query opt: fe check query to enable opt * do not use topn opt for order by string type * fix nullpointer when check type * support more types and using TypeIndex in runtime_predicate * [enhance-WIP](topn-two-phase) implement topn two phase read (apache#783) * [fix](topn) fix conjunct_expr_root nullptr (apache#794) * [enhance](topn-two-phase) support VOlapScanNode (apache#799) * [enhance](topn) trick setParallelExecNum(1) when using topn optimization (apache#802) * use HeapSorter when _use_topn_opt or no var length field * remove debug log Co-authored-by: Kang <kxiao.tiger@gmail.com> * [chore](topn-optimize) make code more readable Co-authored-by: Kang <kxiao.tiger@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.