Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New feature](statistics) Step1: Statistics collection framework #7880

Merged
merged 3 commits into from
Feb 16, 2022

Conversation

EmmyMiao87
Copy link
Contributor

Proposed changes

Framework code for statistics collection,
containing only the main data structures, no implementation details.
This pr will not affect any existing code
and users will not be able to create statistics job.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@EmmyMiao87 EmmyMiao87 added the area/statistics Issues or PRS related to statistics label Jan 25, 2022
@EmmyMiao87
Copy link
Contributor Author

Linked #6370

@EmmyMiao87 EmmyMiao87 added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 25, 2022
@EmmyMiao87 EmmyMiao87 force-pushed the statistics_framework branch from b0fd6ac to a9da0d2 Compare January 25, 2022 03:55
/*
* the max unfinished statistics job number
*/
@ConfField(mutable = true, masterOnly = true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a cbo_ prefix for all these config?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@EmmyMiao87 EmmyMiao87 force-pushed the statistics_framework branch from 6a9f058 to 5346581 Compare January 29, 2022 03:19
morningman
morningman previously approved these changes Feb 6, 2022
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmmyMiao87 EmmyMiao87 force-pushed the statistics_framework branch 2 times, most recently from 8e69393 to e1a9a7e Compare February 11, 2022 03:36
morningman
morningman previously approved these changes Feb 11, 2022
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 11, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman
Copy link
Contributor

Compile failed

Framework code for statistics collection,
containing only the main data structures, no implementation details.
This pr will not affect any existing code
and users will not be able to create statistics job.
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Feb 15, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 16, 2022
@EmmyMiao87 EmmyMiao87 merged commit 6ccf9db into apache:master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/statistics Issues or PRS related to statistics kind/feature Categorizes issue or PR as related to a new feature. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants