Throw an exception to spark when the data push fails and there are too many retries #7531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
wangshuo128
reviewed
Dec 30, 2021
...on/spark-doris-connector/src/main/scala/org/apache/doris/spark/sql/DorisStreamLoadSink.scala
Outdated
Show resolved
Hide resolved
…s/spark/sql/DorisStreamLoadSink.scala Co-authored-by: Shuo Wang <wangshuo128@gmail.com>
github-actions
bot
removed
the
approved
jackwener
reviewed
Dec 30, 2021
Comment on lines
101
to
102
| var errMsg = String.format("Failed to load data on BE: %s node and exceeded the max retry times.", dorisStreamLoader.getLoadUrlStr) | ||
| throw new IOException(errMsg) |
There was a problem hiding this comment.
Suggested change
| var errMsg = String.format("Failed to load data on BE: %s node and exceeded the max retry times.", dorisStreamLoader.getLoadUrlStr) | |
| throw new IOException(errMsg) | |
| throw new IOException(s"Failed to load data on BE: ${dorisStreamLoader.getLoadUrlStr} node and exceeded the max retry times.") |
jackwener
reviewed
Dec 30, 2021
|
|
||
| if(!rowsBuffer.isEmpty){ | ||
| logger.warn("Failed to load data on BE: {} node ", dorisStreamLoader.getLoadUrlStr) | ||
| var errMsg = String.format("Failed to load data on BE: %s node and exceeded the max retry times.", dorisStreamLoader.getLoadUrlStr) |
There was a problem hiding this comment.
Suggested change
| var errMsg = String.format("Failed to load data on BE: %s node and exceeded the max retry times.", dorisStreamLoader.getLoadUrlStr) |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
morningman
reviewed
Jan 5, 2022
|
|
||
| if(!rowsBuffer.isEmpty){ | ||
| logger.warn("Data that failed to load : " + dorisStreamLoader.listToString(rowsBuffer)) | ||
| logger.warn("Failed to load data on BE: {} node ", dorisStreamLoader.getLoadUrlStr) |
There was a problem hiding this comment.
merge these 2 logger.warn
|
|
||
| if(!rowsBuffer.isEmpty){ | ||
| logger.warn("Data that failed to load : " + dorisStreamLoader.listToString(rowsBuffer)) | ||
| logger.warn("Failed to load data on BE: {} node ", dorisStreamLoader.getLoadUrlStr) |
There was a problem hiding this comment.
Merge these 2 logger.warn
github-actions
bot
removed
the
approved
morningman
approved these changes
Jan 9, 2022
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Close related #issue (replace it with issue number if it exists).
Describe the overview of changes, and introduce why we need it.
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...