Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lateral View] Multi lateral views map one TableFunctionNode #7000

Merged
merged 1 commit into from
Nov 17, 2021
Merged

[Lateral View] Multi lateral views map one TableFunctionNode #7000

merged 1 commit into from
Nov 17, 2021

Conversation

EmmyMiao87
Copy link
Contributor

Proposed changes

  1. The first param of explode_view must be string column(VARCHAR/CHAR/STRING)
  2. Add a lateral view tuple id in TableFunctionNode

@EmmyMiao87 EmmyMiao87 linked an issue Nov 3, 2021 that may be closed by this pull request
[Feature] Support Lateral view syntax #6746
Closed
3 tasks
@EmmyMiao87
[Lateral View] Multi lateral views map one TableFunctionNode
e4dd27b 
1. Forbidden non-string column as params of explode_view.
The first param of explode_view must be string column(VARCHAR/CHAR/STRING)

2. N-1 n lateral views map one TableFunctionNode
The TableFunctionNode include all of fnExprs which belongs to one table.
For example:
select pageid,mycol1, mycol2 from pageAds
    lateral view explode_string(col1) myTable1 as mycol1
    lateral view explode_string(col2) myTable2 as mycol2;
TableFunctionNode
|----
|- fnExprList: explode_string(col1), explode_string(col2)
@EmmyMiao87 EmmyMiao87 added the area/sql Issues or PRs related to SQL label Nov 12, 2021
@EmmyMiao87 EmmyMiao87 changed the title [Lateral View] Forbidden non-string column as params of explode_view [Lateral View] Multi lateral views map one TableFunctionNode Nov 16, 2021
morningman
morningman approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 7b71292 into apache:master Nov 17, 2021
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Nov 17, 2021
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morningman morningman morningman approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. area/sql Issues or PRs related to SQL reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Support Lateral view syntax
2 participants
@EmmyMiao87 @morningman