-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Update fe-idea developer guide for latest version #6963
Conversation
@@ -43,12 +43,12 @@ If your are only interested in FE module, and for some reason you can't or don't | |||
the minimum tool required for FE module is `thrift`, so you can manually install `thrift` and copy or create a link of | |||
the executable `thrift` command to `./thirdparty/installed/bin`. | |||
|
|||
Doris build against `thrift` 0.9.3, and `thrift` 0.9.3.1 should also work well, but the newer version will not. | |||
Doris build against `thrift` 0.13.0, and `thrift` 0.13.0 should also work well, but the newer version will not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be noted here that 0.15 and later versions need to use thrift 0.13.0, the previous version is still 0.9.3
then create a soft link to `./thirdparty/installed/bin/thrift`. | ||
|
||
For Windows users, download `thrift` 0.9.3 from `http://archive.apache.org/dist/thrift/0.9.3/thrift-0.9.3.exe`, | ||
For Windows users, download `thrift` 0.13.0 from `http://archive.apache.org/dist/thrift/0.13.0/thrift-0.13.0.exe`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
|
||
If your are using macOS, try `brew install thrift@0.9` and will get `thrift` 0.9.3.1 installed at `/usr/local/opt/thrift@0.9/bin/thrift`, | ||
If your are using macOS, try `brew install thrift@0.13.0` and will get `thrift` 0.13.0 installed at `/usr/local/opt/thrift@0.13.0/bin/thrift`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
|
||
MacOS: `brew install thrift@0.9` | ||
Windows: `http://archive.apache.org/dist/thrift/0.9.3/thrift-0.9.3.exe` | ||
安装 thrift 0.13.0 版本(注意:Doris 基于 thrift 0.13.0 构建, 使用新版本会导致编译不通过) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
Proposed changes
Update fe-idea developer guide for latest version
Types of changes
What types of changes does your code introduce to Doris?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.