Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] fix overflow while convert fixed char to number #6368

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

stdpain
Copy link
Contributor

@stdpain stdpain commented Aug 3, 2021

because Slice::size was unsigned int64, p >= 0 was always true

Proposed changes

Fix potential overflow issues

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)
  • Optimization. Including functional usability improvements and performance improvements.
  • Dependency. Such as changes related to third-party components.
  • Other.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

because Slice::size was unsigned int64, p >= 0 was always true
@morningman morningman added the kind/fix Categorizes issue or PR as related to a bug. label Aug 4, 2021
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2021

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Aug 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2021

PR approved by anyone and no changes requested.

@morningman morningman merged commit b067bdc into apache:master Aug 5, 2021
songchuangyuan pushed a commit to songchuangyuan/incubator-doris that referenced this pull request Aug 20, 2021
because Slice::size was unsigned int64, p >= 0 was always true
@stdpain stdpain deleted the fix_overflow branch September 1, 2021 11:01
@stdpain stdpain restored the fix_overflow branch September 1, 2021 11:01
@stdpain stdpain deleted the fix_overflow branch September 1, 2021 11:01
songchuangyuan pushed a commit to songchuangyuan/incubator-doris that referenced this pull request Oct 18, 2021
because Slice::size was unsigned int64, p >= 0 was always true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. kind/fix Categorizes issue or PR as related to a bug. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants