-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MINOR] Fix the comment about usage of build.sh #6254
Conversation
cc @caiconghui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR.
build.sh
Outdated
# Eg: | ||
# sh build.sh build all | ||
# sh build.sh --be build Backend without clean | ||
# sh build.sh --fe --clean clean and build Frontend and Spark Dpp application |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# sh build.sh --fe --clean clean and build Frontend and Spark Dpp application | |
# sh build.sh --fe --clean clean and build Frontend and Spark Dpp application, without web UI. |
build.sh
Outdated
# Eg: | ||
# sh build.sh build all | ||
# sh build.sh --be build Backend without clean | ||
# sh build.sh --fe --clean clean and build Frontend and Spark Dpp application |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# sh build.sh --fe --clean clean and build Frontend and Spark Dpp application | |
# sh build.sh --fe --clean clean and build Frontend and Spark Dpp application, without web UI. |
build.sh
Outdated
# sh build.sh build all | ||
# sh build.sh --be build Backend without clean | ||
# sh build.sh --fe --clean clean and build Frontend and Spark Dpp application | ||
# sh build.sh --fe --be --clean clean and build Frontend, Spark Dpp application and Backend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# sh build.sh --fe --be --clean clean and build Frontend, Spark Dpp application and Backend | |
# sh build.sh --fe --be --clean clean and build Frontend, Spark Dpp application and Backend, without web UI. |
build.sh
Outdated
# sh build.sh --fe --clean clean and build Frontend and Spark Dpp application | ||
# sh build.sh --fe --be --clean clean and build Frontend, Spark Dpp application and Backend | ||
# sh build.sh --spark-dpp build Spark DPP application alone | ||
# sh build.sh --fe --ui build Frontend web ui with npm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a new entry:
# sh build.sh --fe --be --ui --clean clean and build Frontend, Spark Dpp application, Backend and web UI
Thanks for your time @morningman PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
The usage of build.sh in the current comment is misleading. For example, if we execute with 'sh build.sh -clean', we will get the following error.
Types of changes
What types of changes does your code introduce to Doris?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments