Skip to content

[fix](test) make hive compress split assertion BE-aware#60947

Merged
morningman merged 4 commits intoapache:masterfrom
suxiaogang223:codex/fix-hive-compress-type-be-aware
Mar 3, 2026
Merged

[fix](test) make hive compress split assertion BE-aware#60947
morningman merged 4 commits intoapache:masterfrom
suxiaogang223:codex/fix-hive-compress-type-be-aware

Conversation

@suxiaogang223
Copy link
Contributor

What problem does this PR solve?

Issue Number: N/A

Related PR: N/A

Problem Summary:
external_table_p0/hive/test_hive_compress_type.groovy had a fixed split assertion (28) for multi-BE, which is not stable across environments.
The split behavior for COUNT pushdown depends on both backendNum and parallel_fragment_exec_instance_num, so internal 3BE pipeline could still produce 16 and fail.

This PR makes the assertion BE-aware and deterministic:

  • read backendNum via show backends
  • read parallel_fragment_exec_instance_num via show variables
  • compute expected split count with the same condition as FE logic
  • add comments to explain why this check differs between environments

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Mar 2, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@suxiaogang223
Copy link
Contributor Author

run buildall

morningman
morningman previously approved these changes Mar 2, 2026
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 2, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Mar 2, 2026
@suxiaogang223
Copy link
Contributor Author

run buildall

@morningman morningman force-pushed the codex/fix-hive-compress-type-be-aware branch from 0eb0004 to aeef59f Compare March 2, 2026 15:15
@morningman
Copy link
Contributor

run buildall

1 similar comment
@suxiaogang223
Copy link
Contributor Author

run buildall

@suxiaogang223 suxiaogang223 force-pushed the codex/fix-hive-compress-type-be-aware branch from 7feeca9 to b208d87 Compare March 3, 2026 08:48
@suxiaogang223
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 3, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

PR approved by at least one committer and no changes requested.

@morningman morningman merged commit 7b41760 into apache:master Mar 3, 2026
30 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 3, 2026
### What problem does this PR solve?

Problem Summary:
`external_table_p0/hive/test_hive_compress_type.groovy` had a fixed
split assertion (`28`) for multi-BE, which is not stable across
environments.
The split behavior for COUNT pushdown depends on both `backendNum` and
`parallel_fragment_exec_instance_num`, so internal 3BE pipeline could
still produce `16` and fail.

This PR makes the assertion BE-aware and deterministic:
- read `backendNum` via `show backends`
- read `parallel_fragment_exec_instance_num` via `show variables`
- compute expected split count with the same condition as FE logic
- add comments to explain why this check differs between environments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.1.x reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants