[Bug-fix] Fix wrong data distribution judgment #6029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Fragment where OlapScanNode is located has three data distribution possibilities. 1. UNPARTITIONED: The scan range of OlapScanNode contains only one instance(BE) 2. RANDOM: Involving multi-partitioned tables in OlapScanNode. 3. HASH_PARTITIONED: The involving table is in the colocate group. For a multi-partition table, although the data in each individual partition is distributed according to the bucketing column, the same bucketing column between different partitions is not necessarily in the same be. So the data distribution is RANDOM. If Doris wrongly plan RANDOM as HASH_PARTITIONED, it will lead to the wrong colocate agg node. The result of query is incorrect. Fixed apache#6028
EmmyMiao87
added
area/colocated
morningman
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The Fragment where OlapScanNode is located has two data distribution possibilities.
For a multi-partition table, although the data in each individual partition is distributed according to the bucketing column,
the same bucketing column between different partitions is not necessarily in the same be.
So the data distribution is RANDOM.
If Doris wrongly plan RANDOM as HASH_PARTITIONED, it will lead to the wrong colocate agg node.
The result of query is incorrect.
Fixed #6028
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.