Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ExportJob ErrorMsg is UNKNOWN when job cancelled cause by time out #5915

Merged
merged 1 commit into from
Jun 30, 2021
Merged

fix ExportJob ErrorMsg is UNKNOWN when job cancelled cause by time out #5915

merged 1 commit into from
Jun 30, 2021

Conversation

WindyGao
Copy link
Contributor

@WindyGao WindyGao commented May 26, 2021

ExportJob ErrorMsg is "type:UNKNOWN; msg: "when job cancelled cause by time out

Proposed changes

"type:TIMEOUT; msg:export exporting job timeout." should be shown

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix ExportJob ErrorMsg is UNKNOWN when job cancelled cause by time out #5914) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

related issue

#5914

@WindyGao
Copy link
Contributor Author

image
Before and after code changes

@WindyGao
Copy link
Contributor Author

@morningman The build was successful last night, why did it fail today
Is there a conflict again?😃

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added area/export kind/improvement approved Indicates a PR has been approved by one committer. labels Jun 28, 2021
@morningman morningman merged commit a475d3e into apache:master Jun 30, 2021
stalary pushed a commit to stalary/doris that referenced this pull request Jul 8, 2021
stalary pushed a commit to stalary/doris that referenced this pull request Jul 9, 2021
stalary pushed a commit to stalary/doris that referenced this pull request Jul 27, 2021
stalary pushed a commit to stalary/doris that referenced this pull request Jul 27, 2021
weizhengte pushed a commit to weizhengte/incubator-doris that referenced this pull request Apr 22, 2022
weizhengte pushed a commit to weizhengte/incubator-doris that referenced this pull request Apr 22, 2022
weizhengte pushed a commit to weizhengte/incubator-doris that referenced this pull request Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/export kind/improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants