[BUG] Fixed some uninitialized variables #5850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
reviewed
May 24, 2021
| @@ -589,8 +594,7 @@ bool CsvScanNode::split_check_fill(const std::string& line, RuntimeState* state) | |||
| } | |||
| } | |||
|
|
|||
| for (std::map<std::string, TMiniLoadEtlFunction>::iterator iter = _column_function_map.begin(); | |||
| iter != _column_function_map.end(); iter++) { | |||
| for (auto iter = _column_function_map.begin(); iter != _column_function_map.end(); ++iter) { | |||
There was a problem hiding this comment.
Suggested change
| for (auto iter = _column_function_map.begin(); iter != _column_function_map.end(); ++iter) { | |
| for (auto& iter = _column_function_map.begin(); iter != _column_function_map.end(); ++iter) { |
There was a problem hiding this comment.
It is not necessary to pass a reference here
iterator won't generate a extra memory copy here
| @@ -436,7 +437,7 @@ void FragmentMgr::_exec_actual(std::shared_ptr<FragmentExecState> exec_state, Fi | |||
| { | |||
| std::lock_guard<std::mutex> lock(_lock); | |||
| _fragment_map.erase(exec_state->fragment_instance_id()); | |||
| if (all_done) { | |||
| if (all_done && fragments_ctx) { | |||
There was a problem hiding this comment.
is it necessary to judge fragments_ctx?
There was a problem hiding this comment.
std::shared_ptr<QueryFragmentsCtx> fragments_ctx = exec_state->get_fragments_ctx();
bool all_done = false;
// what will happen if fragments_ctx is null ?
if (fragments_ctx != nullptr) {
// decrease the number of unfinished fragments
all_done = fragments_ctx->countdown();
}
// remove exec state after this fragment finished
{
std::lock_guard<std::mutex> lock(_lock);
_fragment_map.erase(exec_state->fragment_instance_id());
if (all_done && fragments_ctx) {
// it seems that the fragments_ctxmay be NULL
_fragments_ctx_map.erase(fragments_ctx->query_id);it seems that the fragments_ctx may be NULL
| @@ -431,7 +430,7 @@ class Roaring64Map { | |||
| bool isSubset(const Roaring64Map& r) const { | |||
| for (const auto& map_entry : roarings) { | |||
| auto roaring_iter = r.roarings.find(map_entry.first); | |||
| if (roaring_iter == roarings.cend()) | |||
| if (roaring_iter == r.roarings.cend()) | |||
There was a problem hiding this comment.
CRoaring has fixed it https://github.com/RoaringBitmap/CRoaring/blob/master/cpp/roaring64map.hh
morningman
added
approved
stdpain
added a commit
to stdpain/incubator-doris
that referenced
this pull request
Jul 8, 2021
Fixed some potential bugs caused by uninitialized variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixed some potential bugs caused by uninitialisation
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...