Skip to content

[fix](delete) Delete should count down latch and clear an agent task when failed #57428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2025
Merged

[fix](delete) Delete should count down latch and clear an agent task when failed #57428

merged 1 commit into from
Nov 7, 2025

Conversation

@TangSiyang2001
Copy link
Collaborator

@TangSiyang2001 TangSiyang2001 commented Oct 28, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 28, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@TangSiyang2001 TangSiyang2001 marked this pull request as draft October 28, 2025 12:06
@TangSiyang2001 TangSiyang2001 force-pushed the fix-delete-job-stuck-on-failure branch 3 times, most recently from d7a756a to 912b718 Compare October 29, 2025 09:22
@TangSiyang2001
Copy link
Collaborator Author

TangSiyang2001 commented Oct 29, 2025

run buildall

@TangSiyang2001 TangSiyang2001 marked this pull request as ready for review October 29, 2025 09:23
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 29, 2025

FE Regression Coverage Report

Increment line coverage 66.67% (14/21) 🎉
Increment coverage report
Complete coverage report

@TangSiyang2001 TangSiyang2001 force-pushed the fix-delete-job-stuck-on-failure branch 2 times, most recently from 8fd99b5 to 406088b Compare October 30, 2025 03:05
@TangSiyang2001
Copy link
Collaborator Author

TangSiyang2001 commented Oct 30, 2025

run buildall

luwei16
luwei16 previously approved these changes Oct 30, 2025
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 30, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Oct 30, 2025

TPC-DS: Total hot run time: 190830 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 406088b9f368e9c3ff70610bf83bd0884e8596d8, data reload: false

query1	1102	406	406	406
query2	6575	1716	1721	1716
query3	6756	224	228	224
query4	26437	23949	23594	23594
query5	4382	655	489	489
query6	351	257	240	240
query7	4648	513	303	303
query8	329	287	264	264
query9	8731	2613	2615	2613
query10	512	357	292	292
query11	15528	15287	14776	14776
query12	201	121	120	120
query13	1701	573	448	448
query14	11733	9314	9273	9273
query15	212	198	186	186
query16	7842	728	558	558
query17	1716	884	652	652
query18	2051	458	361	361
query19	254	218	198	198
query20	139	129	146	129
query21	222	135	119	119
query22	4621	4634	4580	4580
query23	34733	33741	33838	33741
query24	8434	2532	2519	2519
query25	691	550	522	522
query26	1274	293	174	174
query27	2720	525	399	399
query28	4890	2262	2234	2234
query29	856	653	519	519
query30	306	235	217	217
query31	945	868	780	780
query32	86	70	73	70
query33	612	386	369	369
query34	825	926	560	560
query35	849	855	843	843
query36	1030	1118	973	973
query37	132	127	103	103
query38	3644	3574	3481	3481
query39	1547	1443	1431	1431
query40	225	130	120	120
query41	60	59	59	59
query42	125	124	116	116
query43	494	499	471	471
query44	1213	750	738	738
query45	185	182	174	174
query46	902	989	640	640
query47	1774	1879	1744	1744
query48	412	445	327	327
query49	774	512	430	430
query50	650	678	410	410
query51	3890	3968	3784	3784
query52	109	107	97	97
query53	239	259	201	201
query54	605	602	542	542
query55	86	87	85	85
query56	319	335	309	309
query57	1201	1200	1126	1126
query58	282	288	276	276
query59	2611	2730	2507	2507
query60	339	344	325	325
query61	154	163	150	150
query62	800	723	705	705
query63	226	195	193	193
query64	4412	1173	865	865
query65	4131	3976	3941	3941
query66	1082	433	325	325
query67	15470	15587	15155	15155
query68	8251	933	597	597
query69	467	323	305	305
query70	1361	1286	1355	1286
query71	486	345	333	333
query72	5762	4904	4904	4904
query73	614	561	360	360
query74	8899	9118	8706	8706
query75	3898	3338	2855	2855
query76	3421	1171	756	756
query77	797	432	332	332
query78	9637	9783	8916	8916
query79	1870	803	595	595
query80	641	586	508	508
query81	501	256	235	235
query82	432	168	137	137
query83	309	265	255	255
query84	322	119	101	101
query85	919	489	443	443
query86	338	307	316	307
query87	3729	3837	3644	3644
query88	2938	2237	2227	2227
query89	401	324	295	295
query90	1955	215	217	215
query91	173	171	137	137
query92	82	70	71	70
query93	1139	988	657	657
query94	715	448	349	349
query95	409	330	324	324
query96	495	556	279	279
query97	2953	2987	2869	2869
query98	241	218	214	214
query99	1433	1423	1328	1328
Total cold run time: 277975 ms
Total hot run time: 190830 ms

@doris-robot
Copy link

doris-robot commented Oct 30, 2025

ClickBench: Total hot run time: 27.69 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 406088b9f368e9c3ff70610bf83bd0884e8596d8, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.05	0.05
query3	0.25	0.09	0.09
query4	1.61	0.13	0.12
query5	0.29	0.27	0.26
query6	1.17	0.67	0.64
query7	0.02	0.03	0.03
query8	0.06	0.04	0.05
query9	0.61	0.54	0.52
query10	0.59	0.58	0.58
query11	0.17	0.12	0.12
query12	0.15	0.15	0.12
query13	0.62	0.61	0.60
query14	1.01	1.01	1.00
query15	0.86	0.84	0.86
query16	0.39	0.39	0.39
query17	1.02	1.02	1.03
query18	0.22	0.20	0.20
query19	1.89	1.83	1.75
query20	0.02	0.02	0.01
query21	15.47	0.22	0.12
query22	4.86	0.07	0.05
query23	15.70	0.26	0.10
query24	2.68	0.55	0.84
query25	0.08	0.06	0.07
query26	0.15	0.13	0.13
query27	0.07	0.05	0.05
query28	5.01	1.16	0.94
query29	12.58	3.95	3.25
query30	0.30	0.14	0.13
query31	2.83	0.60	0.37
query32	3.24	0.54	0.46
query33	3.01	3.04	3.07
query34	15.76	5.14	4.56
query35	4.59	4.64	4.57
query36	0.67	0.51	0.50
query37	0.10	0.07	0.07
query38	0.07	0.05	0.04
query39	0.04	0.03	0.03
query40	0.19	0.16	0.14
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 98.66 s
Total hot run time: 27.69 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 30, 2025

BE UT Coverage Report

Increment line coverage 33.33% (1/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.75% (18067/34250)
Line Coverage 37.99% (163851/431351)
Region Coverage 32.34% (124886/386180)
Branch Coverage 33.72% (54616/161991)

@TangSiyang2001 TangSiyang2001 force-pushed the fix-delete-job-stuck-on-failure branch from 406088b to 01fb104 Compare October 30, 2025 06:53
@TangSiyang2001
Copy link
Collaborator Author

TangSiyang2001 commented Oct 30, 2025

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 30, 2025
@doris-robot
Copy link

doris-robot commented Oct 30, 2025

ClickBench: Total hot run time: 27.96 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 01fb10472a5b1910af581abb27931d2e8b3f13ff, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.05	0.06
query3	0.26	0.09	0.08
query4	1.61	0.12	0.12
query5	0.28	0.27	0.26
query6	1.18	0.65	0.64
query7	0.03	0.03	0.03
query8	0.05	0.04	0.05
query9	0.66	0.54	0.53
query10	0.59	0.59	0.58
query11	0.16	0.11	0.11
query12	0.16	0.13	0.12
query13	0.63	0.60	0.61
query14	1.02	1.02	1.01
query15	0.86	0.86	0.87
query16	0.39	0.40	0.39
query17	1.01	1.05	1.04
query18	0.22	0.20	0.20
query19	1.93	1.83	1.85
query20	0.02	0.02	0.01
query21	15.45	0.19	0.13
query22	5.11	0.07	0.05
query23	15.63	0.29	0.11
query24	2.92	0.65	0.43
query25	0.08	0.07	0.06
query26	0.15	0.14	0.13
query27	0.06	0.06	0.05
query28	4.22	1.15	0.94
query29	12.68	4.02	3.33
query30	0.28	0.13	0.13
query31	2.83	0.61	0.40
query32	3.24	0.56	0.49
query33	3.12	3.07	3.14
query34	15.87	5.19	4.64
query35	4.62	4.61	4.56
query36	0.67	0.52	0.49
query37	0.10	0.07	0.07
query38	0.07	0.05	0.04
query39	0.04	0.04	0.03
query40	0.18	0.16	0.16
query41	0.10	0.04	0.03
query42	0.04	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 98.71 s
Total hot run time: 27.96 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 30, 2025

BE UT Coverage Report

Increment line coverage 33.33% (1/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.72% (18042/34224)
Line Coverage 37.97% (163736/431244)
Region Coverage 32.34% (124879/386099)
Branch Coverage 33.71% (54587/161953)

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 30, 2025

FE UT Coverage Report

Increment line coverage 0.00% (0/23) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 30, 2025

BE Regression && UT Coverage Report

Increment line coverage 33.33% (1/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.44% (24023/33628)
Line Coverage 57.84% (249743/431787)
Region Coverage 52.94% (207255/391503)
Branch Coverage 54.65% (89085/163002)

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 30, 2025

FE Regression Coverage Report

Increment line coverage 69.57% (16/23) 🎉
Increment coverage report
Complete coverage report

@TangSiyang2001
Copy link
Collaborator Author

TangSiyang2001 commented Nov 1, 2025

run external

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 1, 2025
@gavinchou gavinchou self-requested a review November 5, 2025 05:44
@dataroaring dataroaring merged commit f12f15c into apache:master Nov 7, 2025
29 of 31 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 7, 2025
@TangSiyang2001
[fix](delete) Delete should count down latch and clear an agent task …
cf0dfd8 
…when failed (#57428)
@github-actions github-actions bot mentioned this pull request Nov 7, 2025
Merged
yiguolei pushed a commit that referenced this pull request Nov 8, 2025
@github-actions @TangSiyang2001
branch-4.0: [fix](delete) Delete should count down latch and clear an…
8cf89ce 
… agent task when failed #57428 (#57779)

Cherry-picked from #57428

Co-authored-by: Siyang Tang <tangsiyang@selectdb.com>
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Nov 18, 2025
@TangSiyang2001 @wyxxxcat
[fix](delete) Delete should count down latch and clear an agent task …
3df4b1c 
…when failed (apache#57428)
TangSiyang2001 added a commit to TangSiyang2001/doris that referenced this pull request Nov 21, 2025
@TangSiyang2001
[fix](delete) Delete should count down latch and clear an agent task …
98d5c55 
…when failed (apache#57428)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@luwei16 luwei16 luwei16 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.x dev/3.1.x-conflict dev/4.0.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@TangSiyang2001 @hello-stephen @doris-robot @gavinchou @luwei16 @yiguolei @dataroaring