Added bounds check in ColumnVector::insert_indices_from()#56696
Open
msridhar78 wants to merge 6 commits intoapache:masterfrom
Open
Added bounds check in ColumnVector::insert_indices_from()#56696msridhar78 wants to merge 6 commits intoapache:masterfrom
msridhar78 wants to merge 6 commits intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-DS: Total hot run time: 190842 ms |
ClickBench: Total hot run time: 30.48 s |
yiguolei
reviewed
Oct 1, 2025
be/src/vec/columns/column_vector.cpp
Outdated
| const uint32_t* __restrict begin, const uint32_t* __restrict end, size_t src_size) { | ||
| for (const auto* it = begin; it != end; ++it) { | ||
| if (*it >= src_size) { | ||
| throw Exception(ErrorCode::INTERNAL_ERROR, |
Contributor
There was a problem hiding this comment.
Is this row level check really useful? Because I think if we check the bound every line the performance may not be very well.
I think we could add the bound check at line 282, it is enough?
Contributor
Author
There was a problem hiding this comment.
This check is made to ensure that each index *it is less than src_size before accessing src[*it] - the UT attached simulates this error condition and hence this check..please let me know your thoughts
msridhar78
force-pushed
the
column_vector_crash_issue
branch
from
a88c159 to
0149e48
Compare
Contributor
Author
|
run buildall |
ClickBench: Total hot run time: 30.03 s |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
TPC-DS: Total hot run time: 189629 ms |
ClickBench: Total hot run time: 30.23 s |
Contributor
Author
|
run buildall |
TPC-DS: Total hot run time: 190363 ms |
ClickBench: Total hot run time: 29.82 s |
Contributor
Author
|
run buildall |
TPC-DS: Total hot run time: 189978 ms |
ClickBench: Total hot run time: 30.8 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
TPC-DS: Total hot run time: 190130 ms |
ClickBench: Total hot run time: 30.03 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Crash similar to Co
(gdb) bt
#0 0x0000555575a42b26 in doris::vectorized::ColumnVector<(doris::PrimitiveType)6>::insert_indices_from(doris::vectorized::IColumn const&, unsigned int const*, unsigned int const*)::{lambda(long const*, long*, unsigned int const*, unsigned int const*)#1}::operator()(long const*, long*, unsigned int const*, unsigned int const*) const (this=0x7fffffffc9df, src=0x7ffff2f73010, dest=0x7ffff2f74048,
begin=0x7fffffffcb50, end=0x7fffffffcb60) at /root/doris/be/src/vec/columns/column_vector.cpp:289
#1 0x00005555759d1ae9 in doris::vectorized::ColumnVector<(doris::PrimitiveType)6>::insert_indices_from (this=0x7ffff2fe0bc0, src=...,
indices_begin=0x7fffffffcb50, indices_end=0x7fffffffcb60) at /root/doris/be/src/vec/columns/column_vector.cpp:293
#2 0x0000555569dfaff6 in doris::vectorized::VColumnVectorTest_insert_indices_from_uInt64_crash_Test::TestBody (this=0x7ffff31350a0)
at /root/doris/be/test/vec/core/column_vector_test.cpp:66
#3 0x000055557af8b4d4 in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::)(), char const) ()
#4 0x000055557af7aad6 in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::)(), char const) ()
#5 0x000055557af55647 in testing::Test::Run() ()
#6 0x000055557af5632d in testing::TestInfo::Run() ()
#7 0x000055557af56ac0 in testing::TestSuite::Run() ()
#8 0x000055557af6827c in testing::internal::UnitTestImpl::RunAllTests() ()
#9 0x000055557af8d304 in bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::)(), char const) ()
#10 0x000055557af7ccf6 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::)(), char const) ()
#11 0x000055557af67e0b in testing::UnitTest::Run() ()
#12 0x000055556903dae3 in RUN_ALL_TESTS () at /var/local/thirdparty/installed/include/gtest/gtest.h:2490
#13 0x00005555690338c0 in main (argc=1, argv=0x7fffffffdc18) at /root/doris/be/test/testutil/run_all_tests.cpp:111
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)