Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metric] Add metrics for routine load #5641

Merged
merged 2 commits into from
Apr 19, 2021

Conversation

morningman
Copy link
Contributor

Proposed changes

Add following metrics for routine load:
doris_fe_job{job="load", type="ROUTINE_LOAD", state="NEED_SCHEDULE"} 0
doris_fe_job{job="load", type="ROUTINE_LOAD", state="RUNNING"} 1
doris_fe_job{job="load", type="ROUTINE_LOAD", state="PAUSED"} 0
doris_fe_job{job="load", type="ROUTINE_LOAD", state="STOPPED"} 0
doris_fe_job{job="load", type="ROUTINE_LOAD", state="CANCELLED"} 0

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Add following metrics for routine load:
doris_fe_job{job="load", type="ROUTINE_LOAD", state="NEED_SCHEDULE"} 0
doris_fe_job{job="load", type="ROUTINE_LOAD", state="RUNNING"} 1
doris_fe_job{job="load", type="ROUTINE_LOAD", state="PAUSED"} 0
doris_fe_job{job="load", type="ROUTINE_LOAD", state="STOPPED"} 0
doris_fe_job{job="load", type="ROUTINE_LOAD", state="CANCELLED"} 0
@morningman morningman added the area/metrics Issues or PRs related to the metrics label Apr 13, 2021
@morningman morningman self-assigned this Apr 13, 2021
@@ -49,13 +49,14 @@
public class TimeUtils {
private static final Logger LOG = LogManager.getLogger(TimeUtils.class);

public static final String UTC_TIME_ZONE = "Africa/Abidjan";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain why Africa/Abidjan

Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangzhg yangzhg added the approved Indicates a PR has been approved by one committer. label Apr 14, 2021
@yangzhg yangzhg merged commit 4313639 into apache:master Apr 19, 2021
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request May 14, 2021
* [Metric] Add metrics for routine load

Add following metrics for routine load:
doris_fe_job{job="load", type="ROUTINE_LOAD", state="NEED_SCHEDULE"} 0
doris_fe_job{job="load", type="ROUTINE_LOAD", state="RUNNING"} 1
doris_fe_job{job="load", type="ROUTINE_LOAD", state="PAUSED"} 0
doris_fe_job{job="load", type="ROUTINE_LOAD", state="STOPPED"} 0
doris_fe_job{job="load", type="ROUTINE_LOAD", state="CANCELLED"} 0

* change UTC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/metrics Issues or PRs related to the metrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants