Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix bug that tablets are not dropped when replacing tables #5627

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

morningman
Copy link
Contributor

@morningman morningman commented Apr 10, 2021

Proposed changes

When replacing table with swap = false, the origin table's tablets
should be removed from tablet inverted index.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix TabletNum has increased sharply than before #5626 ) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

When replacing table with swap = false, the origin table's tablets
should be removed from tablet inverted index.
@morningman morningman added kind/fix Categorizes issue or PR as related to a bug. area/catalog Issues or PRs related to catalog management labels Apr 10, 2021
@morningman morningman self-assigned this Apr 10, 2021
Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangzhg yangzhg added the approved Indicates a PR has been approved by one committer. label Apr 14, 2021
@yangzhg yangzhg merged commit 6be03f3 into apache:master Apr 19, 2021
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request May 14, 2021
…che#5627)

When replacing table with swap = false, the origin table's tablets
should be removed from tablet inverted index.

Co-authored-by: xxiao2018 <benghua3_1@sina.com>
levy5307 pushed a commit to levy5307/incubator-doris that referenced this pull request Nov 14, 2022
…che#5627)

When replacing table with swap = false, the origin table's tablets
should be removed from tablet inverted index.

Co-authored-by: xxiao2018 <benghua3_1@sina.com>
Conflicts:
	fe/fe-core/src/main/java/org/apache/doris/alter/Alter.java
	fe/fe-core/src/test/java/org/apache/doris/alter/AlterTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/catalog Issues or PRs related to catalog management kind/fix Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TabletNum has increased sharply than before
3 participants