Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Update PULL_REQUEST_TEMPLATE.md: a reword suggestion #5240

Merged
merged 1 commit into from
Jan 15, 2021
Merged

[Doc] Update PULL_REQUEST_TEMPLATE.md: a reword suggestion #5240

merged 1 commit into from
Jan 15, 2021

Conversation

Sunt-ing
Copy link

This is a basic grammatical modification suggestion, which will not break any existing build.

Proposed changes

A reword suggestion. Change
from "I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail"
to "I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail"

Targets:

  1. Eliminate a basic grammar error.
  2. Eliminate word redundancy, because redundancy makes the statement a little harder to understand. After changed, the statement gets a little more elegant.

Types of changes

  • [] Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

The PR is very clear, and thus I think no issue is needed.
It's a simple reword suggestion, which will not break our project.

Further comments

It's very simple, and thus I don't think any additional comment is needed.

Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangzhg yangzhg added approved Indicates a PR has been approved by one committer. kind/docs Categorizes issue or PR as related to documentation. labels Jan 14, 2021
@yangzhg yangzhg merged commit 449ba1e into apache:master Jan 15, 2021
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. kind/docs Categorizes issue or PR as related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants