Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Thirdparty] use the bundle source when build_arrow #5179

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

vagetablechicken
Copy link
Contributor

Proposed changes

use bundle source of zstd & double-conversion, instead of system.

Fix #4827

@morningman
Copy link
Contributor

Duplicate in #5187

@vagetablechicken
Copy link
Contributor Author

vagetablechicken commented Jan 3, 2021

Duplicate in #5187

zstd, doublle-conversion, etc. are arrow's thirdparties, we can use arrow's config to build them, no need to write script funcs. I think this way is better.

@yangzhg
Copy link
Member

yangzhg commented Jan 4, 2021

write

may be use bundle is better

Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit d46b57f into apache:master Jan 4, 2021
@yangzhg yangzhg mentioned this pull request Jan 4, 2021
2 tasks
yangzhg added a commit that referenced this pull request Jan 5, 2021
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request Jan 26, 2021
)

use bundle source of zstd & double-conversion, instead of system.
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failed in CentOS 7
3 participants