Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Fill assignment param of bucket shuffle and colocate shuffle for debug #5167

Merged
merged 43 commits into from
Jan 16, 2021

Conversation

xinghuayu007
Copy link
Contributor

Proposed changes

When Doris is in debug mode, function Coordinator#traceInstance is used to print the phsical execute plan of a fragment instance for debug. Function Coordinator#traceInstance uses param scanRangeAssignment to print the detail of a fragment. But bucket shuffle join and colocate shuffle join do not fil the param. That will cause debug not work availablely.
This path fill assignment param of bucket shuffle and colocate shuffle for debug.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

wangxixu added 30 commits August 13, 2020 22:09
Copy link
Contributor

@kangkaisen kangkaisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kangkaisen kangkaisen added approved Indicates a PR has been approved by one committer. kind/improvement labels Jan 4, 2021
@morningman
Copy link
Contributor

There are failure case in p0 test, I will look deep into it. please wait for a moment.

@morningman morningman merged commit 3dcbbbe into apache:master Jan 16, 2021
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request Jan 26, 2021
…uffle for debug (apache#5167)

When Doris is in debug mode, function `Coordinator#traceInstance` is used to print
the physical execute plan of a fragment instance for debug.
Function  `Coordinator#traceInstance` uses param `scanRangeAssignment` to print
the detail of a fragment. But bucket shuffle join and colocate shuffle join do not fill the param.
That will cause debug not work well.
This path fill assignment param of bucket shuffle and colocate shuffle for debug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. kind/improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants