Fix MaterializedView select with CTE bug #5165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmyMiao87
reviewed
Dec 29, 2020
| @@ -86,7 +86,7 @@ | |||
|
|
|||
| private final PlannerContext ctx_; | |||
| private final ArrayList<ScanNode> scanNodes = Lists.newArrayList(); | |||
| private Map<UUID, List<ScanNode>> selectStmtToScanNodes = Maps.newHashMap(); | |||
| private Map<Analyzer, List<ScanNode>> selectStmtToScanNodes = Maps.newHashMap(); | |||
There was a problem hiding this comment.
Is the Analyzer of CTE same as outer query?
There was a problem hiding this comment.
No.
For SQL
select id, t1 from(
select id, a as t1 from t
union all
select id, aaa as t1 from t
) k2;
The analyzer instances for select id, a as t1 from t and select id, aaa as t1 from t are different.
Such as, The analyzer instances for select id, a as t1 from t is 6177, which ancestors are[6219,6220,6221],
The analyzer instances for select id, aaa as t1 from t is 6225, which ancestors are[6247,6220,6221].
EmmyMiao87
added
area/materialized-view
|
Hi, @kangkaisen , there are unused imports: Please fix it first. |
@morningman done |
EmmyMiao87
pushed a commit
to EmmyMiao87/incubator-doris
that referenced
this pull request
Jan 26, 2021
Change-Id: I48d6e57ec0beb91606a464f9eb4c45aadec1fc27
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5164
For different Analyzer scopes, the id for SelectStmt maybe the same, but the Analyzer instance always unique