Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check if ninja exist to build.sh #5099

Merged
merged 1 commit into from
Dec 19, 2020
Merged

Conversation

yangzhg
Copy link
Member

@yangzhg yangzhg commented Dec 17, 2020

Proposed changes

Add a check of ninja exist to build.sh

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] If this change need a document change, I have updated the document
  • [] Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added kind/chore Issues or PRs related to compile and install approved Indicates a PR has been approved by one committer. labels Dec 18, 2020
@morningman morningman merged commit 5f28686 into apache:master Dec 19, 2020
@yangzhg yangzhg deleted the opt_ninja branch December 22, 2020 07:12
morningman pushed a commit to baidu-doris/incubator-doris that referenced this pull request Jan 5, 2021
Add a check of ninja exist to build.sh

Change-Id: If0dd3b5f36128a86664faddb48905376120e8f0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. kind/chore Issues or PRs related to compile and install
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants