Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refine](time) Support more time cast formats and refine some code. #49792

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Mryange
Copy link
Contributor

@Mryange Mryange commented Apr 3, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Mryange
Copy link
Contributor Author

Mryange commented Apr 3, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34270 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9f782ca91a188b3b5b59487d80bc071bdd0f4c15, data reload: false

------ Round 1 ----------------------------------
q1	26051	4985	4991	4985
q2	2051	293	186	186
q3	10396	1238	706	706
q4	10216	1005	522	522
q5	7547	2422	2361	2361
q6	186	162	131	131
q7	923	749	604	604
q8	9340	1284	1090	1090
q9	6829	5196	5164	5164
q10	6874	2307	1884	1884
q11	493	285	263	263
q12	350	355	217	217
q13	17775	3667	3132	3132
q14	227	230	205	205
q15	521	489	491	489
q16	639	621	597	597
q17	605	862	373	373
q18	7539	7092	7146	7092
q19	1310	959	578	578
q20	337	334	224	224
q21	4196	3348	2491	2491
q22	1079	1006	976	976
Total cold run time: 115484 ms
Total hot run time: 34270 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5129	5124	5111	5111
q2	245	324	228	228
q3	2153	2678	2282	2282
q4	1448	1785	1464	1464
q5	4452	4428	4366	4366
q6	221	172	123	123
q7	1956	1916	1745	1745
q8	2638	2611	2508	2508
q9	7334	7240	7067	7067
q10	3002	3355	2732	2732
q11	602	508	476	476
q12	703	798	624	624
q13	3485	3916	3320	3320
q14	311	311	261	261
q15	545	497	509	497
q16	676	688	677	677
q17	1157	1644	1370	1370
q18	7667	7778	7581	7581
q19	854	820	886	820
q20	1899	1959	1834	1834
q21	5401	4847	4898	4847
q22	1124	1041	1054	1041
Total cold run time: 53002 ms
Total hot run time: 50974 ms

@Mryange Mryange marked this pull request as ready for review April 3, 2025 08:42
@Mryange
Copy link
Contributor Author

Mryange commented Apr 3, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34517 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6f621bdd23db8e14f28fd6c52c694e8e562d738e, data reload: false

------ Round 1 ----------------------------------
q1	25884	5070	5002	5002
q2	2065	280	178	178
q3	10399	1293	694	694
q4	10215	1005	538	538
q5	7529	2415	2351	2351
q6	194	169	130	130
q7	1018	762	617	617
q8	9317	1279	1054	1054
q9	6968	5220	5184	5184
q10	6828	2313	1905	1905
q11	483	287	269	269
q12	346	360	222	222
q13	17785	3652	3132	3132
q14	242	226	208	208
q15	554	505	514	505
q16	639	628	565	565
q17	613	870	384	384
q18	7704	7268	7252	7252
q19	1219	972	566	566
q20	346	344	237	237
q21	4405	2775	2527	2527
q22	1105	1027	997	997
Total cold run time: 115858 ms
Total hot run time: 34517 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5127	5129	5104	5104
q2	244	330	230	230
q3	2171	2683	2286	2286
q4	1458	1860	1416	1416
q5	4240	4114	4134	4114
q6	211	166	128	128
q7	1846	1814	1655	1655
q8	2513	2476	2431	2431
q9	6862	6803	6847	6803
q10	2923	3087	2671	2671
q11	565	493	466	466
q12	652	738	561	561
q13	3405	3691	3116	3116
q14	261	286	249	249
q15	526	499	488	488
q16	632	683	639	639
q17	1101	1512	1355	1355
q18	7354	7096	7034	7034
q19	806	815	907	815
q20	1959	1928	1794	1794
q21	5172	4794	4710	4710
q22	1054	1069	1008	1008
Total cold run time: 51082 ms
Total hot run time: 49073 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186374 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6f621bdd23db8e14f28fd6c52c694e8e562d738e, data reload: false

query1	972	489	474	474
query2	6091	1940	1968	1940
query3	6435	245	225	225
query4	25203	23572	22809	22809
query5	4627	635	469	469
query6	303	209	193	193
query7	4653	477	278	278
query8	279	236	237	236
query9	8652	2599	2582	2582
query10	435	316	257	257
query11	15448	14941	14850	14850
query12	162	110	106	106
query13	1661	489	393	393
query14	9431	6116	6214	6116
query15	218	190	169	169
query16	7257	625	490	490
query17	1164	738	601	601
query18	2000	418	320	320
query19	191	189	159	159
query20	119	115	115	115
query21	217	129	107	107
query22	4394	4459	4230	4230
query23	33862	32964	32825	32825
query24	8431	2351	2355	2351
query25	534	452	393	393
query26	1226	265	154	154
query27	2739	495	319	319
query28	4320	2445	2384	2384
query29	889	550	426	426
query30	280	240	189	189
query31	979	860	768	768
query32	101	65	64	64
query33	560	369	313	313
query34	788	858	516	516
query35	795	830	740	740
query36	968	981	901	901
query37	115	98	80	80
query38	4104	4206	3996	3996
query39	1445	1441	1384	1384
query40	216	124	110	110
query41	58	62	56	56
query42	119	111	105	105
query43	507	508	493	493
query44	1284	803	799	799
query45	175	170	166	166
query46	830	1019	618	618
query47	1765	1855	1763	1763
query48	407	412	300	300
query49	789	525	423	423
query50	656	667	432	432
query51	4176	4150	4091	4091
query52	105	107	98	98
query53	221	259	180	180
query54	617	569	501	501
query55	82	80	85	80
query56	303	287	285	285
query57	1146	1142	1098	1098
query58	291	274	264	264
query59	2627	2855	2709	2709
query60	332	321	305	305
query61	135	145	125	125
query62	804	736	641	641
query63	225	179	188	179
query64	4707	1018	689	689
query65	4346	4258	4293	4258
query66	1169	438	324	324
query67	15705	15568	15698	15568
query68	6790	882	529	529
query69	474	320	273	273
query70	1264	1099	1094	1094
query71	464	314	291	291
query72	5596	4732	5052	4732
query73	721	635	351	351
query74	9097	8980	8964	8964
query75	3760	3233	2687	2687
query76	3636	1181	743	743
query77	797	385	328	328
query78	9995	10082	9297	9297
query79	2038	825	576	576
query80	608	515	445	445
query81	476	272	232	232
query82	473	130	95	95
query83	270	257	236	236
query84	256	102	88	88
query85	799	366	338	338
query86	361	298	287	287
query87	4426	4458	4275	4275
query88	3668	2211	2206	2206
query89	391	310	285	285
query90	1916	213	208	208
query91	142	152	111	111
query92	77	60	61	60
query93	1655	947	587	587
query94	670	408	316	316
query95	377	294	284	284
query96	484	557	279	279
query97	3161	3265	3126	3126
query98	240	216	200	200
query99	1453	1411	1269	1269
Total cold run time: 272380 ms
Total hot run time: 186374 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.29 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6f621bdd23db8e14f28fd6c52c694e8e562d738e, data reload: false

query1	0.04	0.04	0.03
query2	0.13	0.11	0.12
query3	0.25	0.21	0.21
query4	1.59	0.21	0.21
query5	0.61	0.59	0.61
query6	1.20	0.72	0.72
query7	0.02	0.02	0.02
query8	0.05	0.04	0.03
query9	0.57	0.53	0.52
query10	0.58	0.59	0.57
query11	0.15	0.11	0.11
query12	0.14	0.12	0.11
query13	0.61	0.60	0.60
query14	2.82	2.72	2.70
query15	0.92	0.85	0.85
query16	0.39	0.38	0.36
query17	1.02	1.03	1.03
query18	0.22	0.19	0.18
query19	1.89	2.02	1.78
query20	0.01	0.02	0.01
query21	15.38	0.91	0.55
query22	0.73	1.23	0.68
query23	14.94	1.41	0.66
query24	7.12	0.83	1.59
query25	0.41	0.18	0.15
query26	0.68	0.16	0.13
query27	0.06	0.05	0.05
query28	9.41	0.87	0.44
query29	12.59	3.93	3.32
query30	0.24	0.09	0.06
query31	2.83	0.60	0.38
query32	3.24	0.54	0.47
query33	3.02	3.06	3.10
query34	15.83	5.20	4.47
query35	4.58	4.50	4.55
query36	0.66	0.48	0.48
query37	0.08	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.16	0.13	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.41 s
Total hot run time: 31.29 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 99.09% (109/110) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.27% (14004/26790)
Line Coverage 41.01% (120680/294235)
Region Coverage 39.73% (61392/154505)
Branch Coverage 34.36% (30660/89230)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants