[enhancement](cloud) improve the retry policy of cloud mode #49067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 32512 ms |
TPC-DS: Total hot run time: 192688 ms |
ClickBench: Total hot run time: 31.38 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
gavinchou
reviewed
Mar 19, 2025
| int get_dynamic_retry_count() { | ||
| int64_t busyness_percent = get_fdb_client_thread_busyness_percent(); | ||
| if (busyness_percent > config::retry_disable_busyness_threshold) { | ||
| return 0; |
There was a problem hiding this comment.
add bvar to record reduce and disable count
consider latency recorder
gavinchou
reviewed
Mar 19, 2025
| @@ -1402,6 +1402,8 @@ enum MetaServiceCode { | |||
|
|
|||
| SCHEMA_DICT_NOT_FOUND = 11001; | |||
|
|
|||
| KV_TXN_CONFLICT_BUSY = 12001; | |||
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 32545 ms |
TPC-DS: Total hot run time: 184679 ms |
ClickBench: Total hot run time: 30.69 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
|
TeamCity cloud ut coverage result: |
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 33416 ms |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run performance |
|
run cloud_p0 |
TPC-H: Total hot run time: 34717 ms |
TPC-DS: Total hot run time: 192064 ms |
ClickBench: Total hot run time: 32.03 s |
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 34186 ms |
TPC-DS: Total hot run time: 193589 ms |
ClickBench: Total hot run time: 32.13 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
gavinchou
reviewed
Mar 22, 2025
| @@ -264,4 +264,8 @@ CONF_Bool(enable_loopback_address_for_ms, "false"); | |||
| // Which vaults should be recycled. If empty, recycle all vaults. | |||
| // Comma seprated list: recycler_storage_vault_white_list="aaa,bbb,ccc" | |||
| CONF_Strings(recycler_storage_vault_white_list, ""); | |||
|
|
|||
| CONF_mInt32(retry_reduce_busyness_threshold, "80"); | |||
gavinchou
reviewed
Mar 22, 2025
| int get_dynamic_retry_count() { | ||
| int64_t busyness_percent = get_fdb_client_thread_busyness_percent(); | ||
| if (busyness_percent > config::retry_disable_busyness_threshold) { | ||
| g_bvar_busynesss_disable_counter << 1; |
There was a problem hiding this comment.
bvar adder should do
promethues can process qps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.