Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [fix](array index) Fix index build failure when all array column data is null #48231 #48264

Open
wants to merge 1 commit into
base: branch-3.0
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #48231

… is null (#48231)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #47846

Problem Summary:
Fix wrong adding array index for building index.
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Feb 24, 2025
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40533 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 839ee381d748775337e602e4bd48591af64f1b28, data reload: false

------ Round 1 ----------------------------------
q1	17607	7287	7246	7246
q2	2050	187	164	164
q3	10852	1049	1203	1049
q4	10565	742	707	707
q5	7722	2827	2851	2827
q6	233	142	141	141
q7	969	618	598	598
q8	9341	1886	2027	1886
q9	6598	6381	6420	6381
q10	7024	2319	2274	2274
q11	458	252	258	252
q12	436	213	210	210
q13	17986	2944	2968	2944
q14	230	203	219	203
q15	571	526	521	521
q16	671	570	572	570
q17	967	562	544	544
q18	7231	6547	6720	6547
q19	1409	1089	1069	1069
q20	463	206	195	195
q21	3889	3286	3208	3208
q22	1072	1016	997	997
Total cold run time: 108344 ms
Total hot run time: 40533 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7249	7181	7151	7151
q2	325	230	226	226
q3	2901	2971	2912	2912
q4	2066	1864	1825	1825
q5	5705	5725	5695	5695
q6	221	148	141	141
q7	2221	1775	1824	1775
q8	3299	3587	3521	3521
q9	8788	8843	8809	8809
q10	3623	3549	3547	3547
q11	576	491	504	491
q12	792	622	607	607
q13	9011	3164	3127	3127
q14	305	276	300	276
q15	571	523	533	523
q16	666	669	640	640
q17	1846	1624	1592	1592
q18	8225	7718	7708	7708
q19	1646	1456	1463	1456
q20	2063	1877	1860	1860
q21	5478	5301	5308	5301
q22	1146	1012	1012	1012
Total cold run time: 68723 ms
Total hot run time: 60195 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 198293 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 839ee381d748775337e602e4bd48591af64f1b28, data reload: false

query1	1294	932	940	932
query2	6225	2012	2066	2012
query3	10826	4240	4351	4240
query4	66149	28657	23416	23416
query5	4943	464	454	454
query6	425	186	181	181
query7	5618	311	311	311
query8	309	227	213	213
query9	9159	2678	2667	2667
query10	445	271	273	271
query11	17309	15592	15933	15592
query12	160	105	100	100
query13	1516	455	439	439
query14	10184	7665	7152	7152
query15	198	190	186	186
query16	7181	452	511	452
query17	1091	583	593	583
query18	1716	336	324	324
query19	215	162	173	162
query20	124	116	113	113
query21	213	105	107	105
query22	4727	4726	4681	4681
query23	34196	34128	34148	34128
query24	6257	2933	2951	2933
query25	542	433	412	412
query26	654	173	171	171
query27	1836	346	365	346
query28	4323	2447	2473	2447
query29	702	443	429	429
query30	244	162	159	159
query31	1023	825	840	825
query32	64	52	55	52
query33	408	294	279	279
query34	921	510	518	510
query35	848	725	725	725
query36	1102	961	967	961
query37	116	69	65	65
query38	4073	3907	4033	3907
query39	1516	1464	1485	1464
query40	201	95	99	95
query41	49	46	53	46
query42	118	100	100	100
query43	546	487	488	487
query44	1213	831	830	830
query45	184	166	170	166
query46	1179	748	742	742
query47	2072	1935	1989	1935
query48	471	392	395	392
query49	734	397	385	385
query50	861	440	449	440
query51	7420	7181	7315	7181
query52	98	97	89	89
query53	264	179	181	179
query54	562	457	446	446
query55	82	75	78	75
query56	257	245	247	245
query57	1220	1153	1119	1119
query58	212	204	208	204
query59	3201	2880	3006	2880
query60	275	240	259	240
query61	113	110	111	110
query62	832	743	719	719
query63	221	187	185	185
query64	1384	696	634	634
query65	3280	3177	3188	3177
query66	648	298	296	296
query67	16077	15635	15449	15449
query68	4063	582	579	579
query69	431	261	262	261
query70	1188	1138	1129	1129
query71	337	248	250	248
query72	6405	4081	4051	4051
query73	755	359	359	359
query74	10497	9144	9288	9144
query75	3365	2687	2694	2687
query76	2125	1164	1211	1164
query77	514	276	260	260
query78	10671	9661	9635	9635
query79	1130	592	604	592
query80	816	435	430	430
query81	489	236	240	236
query82	440	88	87	87
query83	160	142	142	142
query84	283	77	75	75
query85	834	294	289	289
query86	334	288	283	283
query87	4541	4236	4275	4236
query88	3659	2362	2353	2353
query89	416	296	300	296
query90	2065	182	187	182
query91	181	148	149	148
query92	68	49	49	49
query93	1079	531	540	531
query94	821	287	284	284
query95	345	249	254	249
query96	605	287	283	283
query97	3316	3206	3189	3189
query98	210	205	195	195
query99	1674	1402	1426	1402
Total cold run time: 316443 ms
Total hot run time: 198293 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.72 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 839ee381d748775337e602e4bd48591af64f1b28, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.06	0.06
query4	1.63	0.11	0.10
query5	0.52	0.49	0.51
query6	1.14	0.73	0.73
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.55	0.49	0.50
query10	0.52	0.54	0.56
query11	0.14	0.11	0.10
query12	0.16	0.11	0.11
query13	0.62	0.61	0.60
query14	2.72	2.76	2.78
query15	0.89	0.82	0.84
query16	0.39	0.39	0.37
query17	1.07	1.04	0.96
query18	0.23	0.22	0.23
query19	1.89	1.79	2.03
query20	0.01	0.01	0.01
query21	15.36	0.58	0.57
query22	2.65	2.94	1.65
query23	16.97	1.04	0.84
query24	3.61	1.29	1.26
query25	0.28	0.18	0.05
query26	0.46	0.14	0.13
query27	0.06	0.05	0.04
query28	9.82	1.11	1.08
query29	12.62	3.25	3.22
query30	0.25	0.05	0.05
query31	2.88	0.37	0.38
query32	3.26	0.46	0.45
query33	2.94	3.00	3.00
query34	17.22	4.46	4.55
query35	4.54	4.51	4.52
query36	0.70	0.49	0.51
query37	0.10	0.06	0.07
query38	0.05	0.03	0.04
query39	0.04	0.03	0.02
query40	0.16	0.12	0.12
query41	0.08	0.02	0.03
query42	0.04	0.02	0.02
query43	0.03	0.02	0.03
Total cold run time: 107 s
Total hot run time: 32.72 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants