Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Opt](profile) Add timer for SegmentIterator::_get_row_ranges_by_keys #48191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Feb 21, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Feb 21, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 21, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@bobhan1
Copy link
Contributor Author

bobhan1 commented Feb 22, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31831 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4e7dcc16437e5688e9e30e6589d06822a1689079, data reload: false

------ Round 1 ----------------------------------
q1	17607	5365	5121	5121
q2	2060	294	169	169
q3	10469	1249	788	788
q4	10220	1038	557	557
q5	7575	2464	2342	2342
q6	190	172	138	138
q7	934	772	625	625
q8	9296	1391	1239	1239
q9	4875	4682	4703	4682
q10	6838	2320	1877	1877
q11	476	290	252	252
q12	358	363	228	228
q13	17759	3668	3041	3041
q14	239	246	213	213
q15	550	470	458	458
q16	627	629	584	584
q17	595	865	346	346
q18	6610	6311	6174	6174
q19	1431	947	541	541
q20	327	336	193	193
q21	2763	2187	1966	1966
q22	368	345	297	297
Total cold run time: 102167 ms
Total hot run time: 31831 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5194	5183	5152	5152
q2	236	327	232	232
q3	2160	2735	2338	2338
q4	1435	1871	1391	1391
q5	4229	4136	4154	4136
q6	205	167	125	125
q7	1864	1833	1701	1701
q8	2621	2612	2571	2571
q9	7252	7228	7169	7169
q10	3018	3189	2772	2772
q11	576	537	480	480
q12	699	766	609	609
q13	3497	3800	3363	3363
q14	277	296	279	279
q15	508	457	453	453
q16	651	688	627	627
q17	1137	1637	1308	1308
q18	7662	7472	7337	7337
q19	811	833	966	833
q20	1984	2015	1915	1915
q21	5425	5040	4820	4820
q22	587	571	571	571
Total cold run time: 52028 ms
Total hot run time: 50182 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 189748 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4e7dcc16437e5688e9e30e6589d06822a1689079, data reload: false

query1	1304	944	921	921
query2	6239	1831	1796	1796
query3	11057	4518	4430	4430
query4	57355	24699	23319	23319
query5	5188	551	495	495
query6	427	209	187	187
query7	5480	502	305	305
query8	318	249	227	227
query9	7513	2562	2554	2554
query10	427	309	259	259
query11	15484	15120	14800	14800
query12	167	109	116	109
query13	1394	569	434	434
query14	10568	6797	6452	6452
query15	202	207	182	182
query16	7043	641	523	523
query17	1090	754	583	583
query18	1511	409	323	323
query19	207	193	171	171
query20	134	136	123	123
query21	212	123	107	107
query22	4440	4643	4263	4263
query23	33882	33396	33347	33347
query24	5628	2504	2459	2459
query25	448	469	395	395
query26	737	284	157	157
query27	1900	496	356	356
query28	2777	2501	2442	2442
query29	572	562	432	432
query30	211	189	183	183
query31	918	865	792	792
query32	99	61	59	59
query33	423	372	300	300
query34	761	858	525	525
query35	837	843	754	754
query36	1001	976	923	923
query37	121	96	79	79
query38	4291	4328	4206	4206
query39	1521	1430	1458	1430
query40	210	116	102	102
query41	50	48	49	48
query42	132	115	113	113
query43	513	516	474	474
query44	1359	836	822	822
query45	177	177	167	167
query46	879	1051	659	659
query47	1818	1916	1784	1784
query48	408	423	316	316
query49	694	509	426	426
query50	731	737	435	435
query51	4304	4336	4225	4225
query52	110	113	100	100
query53	238	265	193	193
query54	491	495	404	404
query55	91	80	91	80
query56	282	268	259	259
query57	1160	1179	1132	1132
query58	258	248	244	244
query59	2618	2925	2572	2572
query60	300	289	264	264
query61	125	114	116	114
query62	721	757	688	688
query63	246	201	201	201
query64	1458	1069	705	705
query65	3290	3135	3135	3135
query66	762	403	314	314
query67	15972	15413	15394	15394
query68	5174	779	535	535
query69	505	312	256	256
query70	1232	1155	1133	1133
query71	440	299	265	265
query72	6001	3590	3707	3590
query73	895	749	350	350
query74	8991	9187	8846	8846
query75	3390	3157	2692	2692
query76	3712	1174	822	822
query77	547	369	273	273
query78	10094	10062	9276	9276
query79	2580	825	604	604
query80	651	531	471	471
query81	519	271	235	235
query82	269	124	95	95
query83	169	165	152	152
query84	300	91	76	76
query85	800	336	300	300
query86	362	302	287	287
query87	4357	4427	4273	4273
query88	3734	2203	2191	2191
query89	415	309	281	281
query90	1872	190	191	190
query91	135	166	105	105
query92	76	56	58	56
query93	2385	995	585	585
query94	636	407	299	299
query95	345	272	262	262
query96	505	564	277	277
query97	2786	2842	2725	2725
query98	225	203	204	203
query99	1299	1440	1271	1271
Total cold run time: 298685 ms
Total hot run time: 189748 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.41 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4e7dcc16437e5688e9e30e6589d06822a1689079, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.04	0.03
query3	0.24	0.07	0.07
query4	1.62	0.11	0.11
query5	0.41	0.41	0.44
query6	1.16	0.66	0.64
query7	0.02	0.02	0.01
query8	0.04	0.03	0.04
query9	0.59	0.51	0.54
query10	0.57	0.56	0.58
query11	0.15	0.10	0.10
query12	0.13	0.11	0.11
query13	0.62	0.60	0.61
query14	2.69	2.72	2.68
query15	0.92	0.86	0.85
query16	0.38	0.38	0.38
query17	1.04	1.07	1.06
query18	0.22	0.19	0.20
query19	1.93	1.86	1.99
query20	0.01	0.01	0.01
query21	15.34	0.89	0.55
query22	0.74	1.09	0.66
query23	15.06	1.38	0.64
query24	6.84	2.34	1.43
query25	0.52	0.19	0.21
query26	0.54	0.15	0.14
query27	0.06	0.05	0.05
query28	10.84	0.76	0.44
query29	12.55	3.98	3.32
query30	0.25	0.09	0.06
query31	2.82	0.58	0.38
query32	3.24	0.56	0.47
query33	2.98	3.05	2.97
query34	15.79	5.17	4.53
query35	4.57	4.55	4.59
query36	0.68	0.50	0.47
query37	0.08	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.16	0.13	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.14 s
Total hot run time: 31.41 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 44.50% (11751/26407)
Line Coverage: 34.00% (98247/288967)
Region Coverage: 33.08% (50321/152121)
Branch Coverage: 28.72% (25294/88056)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4e7dcc16437e5688e9e30e6589d06822a1689079_4e7dcc16437e5688e9e30e6589d06822a1689079/report/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.x reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants