-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](mv) Fix use sync mv wrongly when use rbo materialized view rewrite rule #47650
Merged
morrySnow
merged 1 commit into
apache:master
from
seawinde:fix_sync_mv_wrong_hint_when_rbo
Feb 12, 2025
Merged
[fix](mv) Fix use sync mv wrongly when use rbo materialized view rewrite rule #47650
morrySnow
merged 1 commit into
apache:master
from
seawinde:fix_sync_mv_wrong_hint_when_rbo
Feb 12, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
morrySnow
approved these changes
Feb 8, 2025
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 31877 ms
|
TPC-DS: Total hot run time: 183510 ms
|
ClickBench: Total hot run time: 31.94 s
|
shuke987
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-actions bot
pushed a commit
that referenced
this pull request
Feb 12, 2025
…ite rule (#47650) ### What problem does this PR solve? if mv def sql is as following: create matrialized view test_mv as select k1, k3, sum(k2), count(k4) from ${tblName} group by k1, k3; if query are as following, should not use test_mv above select count(k1) from agg_use_key_direct; select sum(k1) from agg_use_key_direct select avg(k1) from agg_use_key_direct the wrong case would happen when in branch-2.1 or `set enable_sync_mv_cost_based_rewrite = false;` on branch-3.0 or master, the pr fix this if query are as following with distinct or is `max` or `min`, can use test_mv above select count(distinct k1) from agg_use_key_direct; select sum(distinct k1) from agg_use_key_direct select avg(distinct k1) from agg_use_key_direct select max(k1) from agg_use_key_direct select min(k1) from agg_use_key_direct
github-actions bot
pushed a commit
that referenced
this pull request
Feb 12, 2025
…ite rule (#47650) ### What problem does this PR solve? if mv def sql is as following: create matrialized view test_mv as select k1, k3, sum(k2), count(k4) from ${tblName} group by k1, k3; if query are as following, should not use test_mv above select count(k1) from agg_use_key_direct; select sum(k1) from agg_use_key_direct select avg(k1) from agg_use_key_direct the wrong case would happen when in branch-2.1 or `set enable_sync_mv_cost_based_rewrite = false;` on branch-3.0 or master, the pr fix this if query are as following with distinct or is `max` or `min`, can use test_mv above select count(distinct k1) from agg_use_key_direct; select sum(distinct k1) from agg_use_key_direct select avg(distinct k1) from agg_use_key_direct select max(k1) from agg_use_key_direct select min(k1) from agg_use_key_direct
lzyy2024
pushed a commit
to lzyy2024/doris
that referenced
this pull request
Feb 21, 2025
…ite rule (apache#47650) ### What problem does this PR solve? if mv def sql is as following: create matrialized view test_mv as select k1, k3, sum(k2), count(k4) from ${tblName} group by k1, k3; if query are as following, should not use test_mv above select count(k1) from agg_use_key_direct; select sum(k1) from agg_use_key_direct select avg(k1) from agg_use_key_direct the wrong case would happen when in branch-2.1 or `set enable_sync_mv_cost_based_rewrite = false;` on branch-3.0 or master, the pr fix this if query are as following with distinct or is `max` or `min`, can use test_mv above select count(distinct k1) from agg_use_key_direct; select sum(distinct k1) from agg_use_key_direct select avg(distinct k1) from agg_use_key_direct select max(k1) from agg_use_key_direct select min(k1) from agg_use_key_direct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
dev/2.1.9-merged
dev/3.0.5-merged
p0_w
reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
if mv def sql is as following:
if query are as following, should not use test_mv above
the wrong case would happen when in branch-2.1 or
set enable_sync_mv_cost_based_rewrite = false;
on branch-3.0 or master, the pr fix thisif query are as following with distinct or is
max
ormin
, can use test_mv aboveIssue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
Fix use sync mv wrongly when use rbo materialized view rewrite rule
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)