Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature](view)Support modify view comment #46910

Merged
merged 1 commit into from
Jan 24, 2025
Merged

[feature](view)Support modify view comment #46910

merged 1 commit into from
Jan 24, 2025

Conversation

Jibing-Li
Copy link
Contributor

@Jibing-Li Jibing-Li commented Jan 13, 2025 •
edited
Loading

What problem does this PR solve?

Support modify view comment:

ALTER VIEW
[db_name.]view_name
MODIFY COMMENT "new comment"

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Jibing-Li Jibing-Li force-pushed the view branch 2 times, most recently from 3a2586b to 490dde8 Compare January 13, 2025 11:38
@Jibing-Li Jibing-Li marked this pull request as ready for review January 13, 2025 11:41
@Jibing-Li
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32879 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 490dde803bc4cadcbce8e83064d52e125e00c4e2, data reload: false

------ Round 1 ----------------------------------
q1	17573	6212	5992	5992
q2	2050	292	165	165
q3	10435	1211	756	756
q4	10210	883	428	428
q5	7503	2193	1951	1951
q6	202	176	143	143
q7	885	744	612	612
q8	9238	1366	1146	1146
q9	5332	4891	4870	4870
q10	6814	2303	1831	1831
q11	489	278	260	260
q12	338	358	219	219
q13	17760	3632	3137	3137
q14	243	238	213	213
q15	553	491	500	491
q16	639	619	581	581
q17	577	857	340	340
q18	7037	6585	6627	6585
q19	1742	965	555	555
q20	329	332	195	195
q21	3028	2209	2094	2094
q22	363	333	315	315
Total cold run time: 103340 ms
Total hot run time: 32879 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6197	6068	6102	6068
q2	241	343	234	234
q3	2251	2677	2295	2295
q4	1408	1804	1399	1399
q5	4365	4727	4787	4727
q6	186	179	138	138
q7	2041	1962	1754	1754
q8	2651	2833	2679	2679
q9	7237	7157	7277	7157
q10	3051	3363	2772	2772
q11	573	526	479	479
q12	678	767	641	641
q13	3498	3916	3317	3317
q14	286	295	278	278
q15	581	528	535	528
q16	667	670	626	626
q17	1226	1764	1253	1253
q18	7779	7374	7467	7374
q19	855	1124	1086	1086
q20	1978	2029	1947	1947
q21	5802	5123	5041	5041
q22	628	610	532	532
Total cold run time: 54179 ms
Total hot run time: 52325 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196105 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 490dde803bc4cadcbce8e83064d52e125e00c4e2, data reload: false

query1	1291	988	917	917
query2	6282	2380	2290	2290
query3	10946	4820	4804	4804
query4	32792	23663	23421	23421
query5	4412	623	460	460
query6	289	193	178	178
query7	4000	485	327	327
query8	285	232	225	225
query9	9267	2663	2663	2663
query10	464	312	252	252
query11	17735	15337	15116	15116
query12	156	109	111	109
query13	1562	527	394	394
query14	9322	7620	7897	7620
query15	253	217	193	193
query16	7947	623	438	438
query17	1606	815	595	595
query18	2000	406	321	321
query19	222	197	177	177
query20	132	122	118	118
query21	215	131	150	131
query22	4417	4521	4541	4521
query23	34056	33352	33343	33343
query24	6434	2402	2337	2337
query25	504	472	406	406
query26	762	293	167	167
query27	1947	468	326	326
query28	5690	2475	2452	2452
query29	612	554	442	442
query30	222	192	151	151
query31	945	883	802	802
query32	76	61	56	56
query33	522	361	304	304
query34	785	842	526	526
query35	813	824	770	770
query36	1024	1033	969	969
query37	129	97	86	86
query38	4076	4184	4098	4098
query39	1521	1624	1435	1435
query40	202	122	108	108
query41	57	53	50	50
query42	127	106	108	106
query43	525	519	495	495
query44	1327	821	832	821
query45	187	167	166	166
query46	880	1061	661	661
query47	1917	2011	1921	1921
query48	377	402	327	327
query49	735	485	397	397
query50	666	658	393	393
query51	7157	7121	6946	6946
query52	102	99	91	91
query53	222	247	178	178
query54	491	531	414	414
query55	84	77	80	77
query56	255	284	247	247
query57	1225	1212	1149	1149
query58	249	235	234	234
query59	3234	3185	3131	3131
query60	280	271	253	253
query61	126	115	120	115
query62	845	800	734	734
query63	230	195	202	195
query64	3216	1033	663	663
query65	3280	3261	3205	3205
query66	824	409	367	367
query67	16243	15656	15449	15449
query68	8991	713	511	511
query69	494	289	265	265
query70	1181	1135	1111	1111
query71	436	293	253	253
query72	5383	3817	3908	3817
query73	655	765	356	356
query74	10275	9217	8896	8896
query75	4628	3158	2650	2650
query76	4295	1189	769	769
query77	793	356	279	279
query78	10096	10017	9365	9365
query79	2456	797	597	597
query80	600	519	430	430
query81	502	266	236	236
query82	304	151	133	133
query83	167	169	155	155
query84	236	96	77	77
query85	736	347	326	326
query86	390	320	294	294
query87	4354	4325	4270	4270
query88	4677	2141	2131	2131
query89	401	313	285	285
query90	1879	183	189	183
query91	135	134	108	108
query92	70	56	54	54
query93	1798	892	531	531
query94	613	391	298	298
query95	340	264	288	264
query96	481	611	278	278
query97	2843	2925	2797	2797
query98	222	206	191	191
query99	1410	1482	1362	1362
Total cold run time: 292617 ms
Total hot run time: 196105 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.52 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 490dde803bc4cadcbce8e83064d52e125e00c4e2, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.03	0.03
query3	0.24	0.07	0.07
query4	1.62	0.10	0.10
query5	0.40	0.41	0.41
query6	1.16	0.65	0.66
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.60	0.51	0.50
query10	0.56	0.56	0.55
query11	0.14	0.10	0.11
query12	0.14	0.11	0.10
query13	0.60	0.61	0.59
query14	2.70	2.81	2.72
query15	0.90	0.84	0.83
query16	0.38	0.37	0.38
query17	1.07	0.97	1.05
query18	0.23	0.21	0.21
query19	1.98	1.79	1.96
query20	0.01	0.01	0.01
query21	15.36	0.96	0.59
query22	0.74	0.87	0.62
query23	15.27	1.39	0.54
query24	3.02	0.37	0.70
query25	0.16	0.22	0.11
query26	0.33	0.15	0.13
query27	0.05	0.06	0.04
query28	12.56	1.61	1.05
query29	12.58	4.11	3.38
query30	0.26	0.09	0.07
query31	2.82	0.60	0.38
query32	3.22	0.54	0.47
query33	3.24	3.13	3.01
query34	16.81	5.13	4.49
query35	4.49	4.43	4.53
query36	0.66	0.50	0.48
query37	0.10	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.03	0.02
query40	0.16	0.13	0.11
query41	0.08	0.03	0.03
query42	0.04	0.02	0.02
query43	0.03	0.02	0.02
Total cold run time: 104.97 s
Total hot run time: 30.52 s

@Jibing-Li
Copy link
Contributor Author

run cloud_p0

@Jibing-Li
Copy link
Contributor Author

run buildall

@Jibing-Li
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32705 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0e5f76cbd5af2e49d668d3a47da6210b46364e3f, data reload: false

------ Round 1 ----------------------------------
q1	17582	6161	6048	6048
q2	2048	315	190	190
q3	10383	1225	719	719
q4	10262	864	435	435
q5	8716	2181	1960	1960
q6	210	183	149	149
q7	910	739	587	587
q8	9228	1341	1152	1152
q9	5223	4799	4892	4799
q10	6756	2309	1870	1870
q11	472	275	260	260
q12	346	356	221	221
q13	17793	3771	3230	3230
q14	232	232	225	225
q15	567	543	523	523
q16	641	606	600	600
q17	577	859	338	338
q18	7086	6597	6425	6425
q19	1809	935	511	511
q20	311	330	199	199
q21	2756	2182	1959	1959
q22	367	327	305	305
Total cold run time: 104275 ms
Total hot run time: 32705 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6265	6206	6568	6206
q2	249	330	238	238
q3	2253	2650	2332	2332
q4	1433	1839	1370	1370
q5	4340	4750	4845	4750
q6	187	175	145	145
q7	2082	1982	1795	1795
q8	2626	2816	2666	2666
q9	7267	7357	7300	7300
q10	3105	3242	2758	2758
q11	608	514	513	513
q12	704	779	618	618
q13	3587	3981	3323	3323
q14	276	300	273	273
q15	573	533	533	533
q16	655	679	639	639
q17	1212	1727	1283	1283
q18	7661	7665	7198	7198
q19	815	1113	1097	1097
q20	1981	2023	1864	1864
q21	5648	5234	5054	5054
q22	604	616	571	571
Total cold run time: 54131 ms
Total hot run time: 52526 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195174 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0e5f76cbd5af2e49d668d3a47da6210b46364e3f, data reload: false

query1	1305	966	919	919
query2	6402	2110	2006	2006
query3	11096	4589	4413	4413
query4	61654	29193	23634	23634
query5	5506	598	500	500
query6	426	198	187	187
query7	5561	511	303	303
query8	334	242	222	222
query9	8314	2735	2706	2706
query10	456	315	240	240
query11	17770	15631	15653	15631
query12	164	110	104	104
query13	1450	557	424	424
query14	10963	7022	6393	6393
query15	238	204	201	201
query16	7388	619	476	476
query17	1131	722	582	582
query18	1945	384	297	297
query19	187	169	156	156
query20	117	115	116	115
query21	207	127	103	103
query22	4674	4682	4470	4470
query23	34054	33741	33660	33660
query24	5573	2310	2305	2305
query25	474	458	403	403
query26	629	273	153	153
query27	1703	459	333	333
query28	4264	2501	2472	2472
query29	508	561	432	432
query30	216	188	158	158
query31	920	913	818	818
query32	65	65	56	56
query33	425	363	290	290
query34	747	858	517	517
query35	790	844	760	760
query36	991	1028	945	945
query37	122	97	81	81
query38	4251	4364	4168	4168
query39	1500	1459	1416	1416
query40	206	113	100	100
query41	53	56	51	51
query42	118	101	110	101
query43	517	526	476	476
query44	1351	859	835	835
query45	180	178	167	167
query46	880	1054	644	644
query47	1920	1922	1892	1892
query48	391	395	332	332
query49	716	478	387	387
query50	652	651	390	390
query51	7169	6975	6925	6925
query52	101	97	93	93
query53	238	251	190	190
query54	483	509	429	429
query55	82	84	91	84
query56	251	266	247	247
query57	1266	1235	1179	1179
query58	236	229	231	229
query59	3093	3154	2807	2807
query60	275	266	304	266
query61	115	111	113	111
query62	791	765	716	716
query63	222	185	186	185
query64	1282	1006	653	653
query65	3235	3131	3132	3131
query66	727	422	303	303
query67	15739	15733	15460	15460
query68	4186	838	546	546
query69	488	288	281	281
query70	1193	1115	1142	1115
query71	417	289	303	289
query72	6322	3852	3830	3830
query73	690	739	358	358
query74	10413	8983	8986	8983
query75	3195	3221	2674	2674
query76	3265	1165	761	761
query77	477	366	281	281
query78	10210	10272	9473	9473
query79	2243	808	606	606
query80	1683	536	435	435
query81	548	273	237	237
query82	380	146	126	126
query83	267	165	148	148
query84	287	158	72	72
query85	762	356	290	290
query86	392	300	307	300
query87	4433	4474	4392	4392
query88	3031	2241	2188	2188
query89	388	319	284	284
query90	1529	187	191	187
query91	128	134	105	105
query92	59	72	53	53
query93	1659	874	540	540
query94	667	404	289	289
query95	321	269	252	252
query96	498	598	298	298
query97	2822	2928	2748	2748
query98	217	197	193	193
query99	1379	1520	1408	1408
Total cold run time: 311358 ms
Total hot run time: 195174 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.27 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0e5f76cbd5af2e49d668d3a47da6210b46364e3f, data reload: false

query1	0.04	0.03	0.02
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.61	0.11	0.11
query5	0.41	0.43	0.41
query6	1.15	0.66	0.65
query7	0.02	0.02	0.02
query8	0.04	0.04	0.04
query9	0.58	0.50	0.52
query10	0.55	0.57	0.56
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.60	0.60
query14	2.69	2.74	2.77
query15	0.89	0.84	0.84
query16	0.38	0.38	0.38
query17	1.01	1.00	1.04
query18	0.23	0.21	0.23
query19	1.89	1.81	2.00
query20	0.01	0.01	0.02
query21	15.36	0.95	0.58
query22	0.75	0.73	0.74
query23	15.27	1.43	0.62
query24	2.93	0.81	1.64
query25	0.16	0.19	0.08
query26	0.36	0.15	0.14
query27	0.05	0.06	0.06
query28	14.00	1.52	1.05
query29	12.61	3.90	3.25
query30	0.26	0.10	0.07
query31	2.81	0.58	0.39
query32	3.23	0.55	0.47
query33	2.98	3.01	2.98
query34	16.89	5.21	4.50
query35	4.59	4.53	4.54
query36	0.64	0.48	0.48
query37	0.09	0.07	0.06
query38	0.06	0.04	0.04
query39	0.04	0.02	0.02
query40	0.16	0.13	0.13
query41	0.07	0.03	0.03
query42	0.04	0.02	0.02
query43	0.03	0.02	0.03
Total cold run time: 106.07 s
Total hot run time: 31.27 s

@Jibing-Li
Copy link
Contributor Author

run cloud_p0

@Jibing-Li
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32747 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 88b1d1a6b7b28534fdc13fbb5b455af61a150101, data reload: false

------ Round 1 ----------------------------------
q1	17594	6166	6063	6063
q2	2056	303	171	171
q3	10423	1232	746	746
q4	10260	866	443	443
q5	8509	2209	1986	1986
q6	213	180	146	146
q7	901	756	625	625
q8	9265	1380	1141	1141
q9	5253	4923	4931	4923
q10	6764	2293	1862	1862
q11	479	275	260	260
q12	341	371	224	224
q13	17827	3717	3106	3106
q14	236	229	218	218
q15	586	529	506	506
q16	643	620	573	573
q17	560	851	315	315
q18	6801	6418	6449	6418
q19	1737	946	540	540
q20	310	317	186	186
q21	2913	2234	1996	1996
q22	361	337	299	299
Total cold run time: 104032 ms
Total hot run time: 32747 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6260	6251	6229	6229
q2	246	340	244	244
q3	2235	2693	2338	2338
q4	1417	1773	1365	1365
q5	4382	4776	4820	4776
q6	192	175	150	150
q7	2037	1948	1826	1826
q8	2656	2816	2727	2727
q9	7312	7346	7338	7338
q10	3104	3313	2767	2767
q11	587	529	510	510
q12	704	792	621	621
q13	3491	3868	3343	3343
q14	275	327	269	269
q15	586	530	535	530
q16	657	686	655	655
q17	1219	1742	1272	1272
q18	7780	7567	7372	7372
q19	808	954	1152	954
q20	1991	2055	1897	1897
q21	5581	5159	5126	5126
q22	568	614	572	572
Total cold run time: 54088 ms
Total hot run time: 52881 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 194665 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 88b1d1a6b7b28534fdc13fbb5b455af61a150101, data reload: false

query1	1305	964	930	930
query2	6428	2008	2012	2008
query3	10986	4399	4468	4399
query4	61270	28986	23182	23182
query5	5501	610	480	480
query6	425	205	185	185
query7	5544	505	302	302
query8	330	251	232	232
query9	8119	2759	2743	2743
query10	447	302	258	258
query11	17303	15403	15677	15403
query12	172	108	110	108
query13	1426	570	446	446
query14	13295	6797	6559	6559
query15	218	204	200	200
query16	6634	637	459	459
query17	1115	744	551	551
query18	1558	398	321	321
query19	217	181	169	169
query20	118	119	110	110
query21	208	121	104	104
query22	4489	4434	4631	4434
query23	34148	33957	33740	33740
query24	5719	2236	2273	2236
query25	469	454	409	409
query26	671	274	153	153
query27	1723	500	338	338
query28	3606	2519	2473	2473
query29	519	558	419	419
query30	214	196	157	157
query31	936	875	812	812
query32	68	60	56	56
query33	424	369	309	309
query34	739	866	516	516
query35	802	838	765	765
query36	999	1056	960	960
query37	118	108	77	77
query38	4284	4284	4179	4179
query39	1475	1466	1456	1456
query40	206	116	105	105
query41	53	50	54	50
query42	121	114	105	105
query43	534	520	480	480
query44	1360	855	843	843
query45	192	186	181	181
query46	909	1074	658	658
query47	1931	1958	1871	1871
query48	443	408	333	333
query49	708	482	408	408
query50	660	654	390	390
query51	7012	6938	6973	6938
query52	104	96	94	94
query53	229	262	183	183
query54	474	496	416	416
query55	82	85	78	78
query56	261	263	261	261
query57	1259	1196	1142	1142
query58	238	238	239	238
query59	3121	3074	2938	2938
query60	275	266	251	251
query61	116	118	114	114
query62	803	762	703	703
query63	220	182	185	182
query64	1361	1020	658	658
query65	3225	3170	3149	3149
query66	732	401	306	306
query67	16125	15866	15507	15507
query68	5022	828	535	535
query69	484	293	274	274
query70	1188	1100	1102	1100
query71	410	289	262	262
query72	6344	3930	3934	3930
query73	806	780	350	350
query74	10116	9247	8817	8817
query75	3255	3139	2682	2682
query76	3788	1179	784	784
query77	484	372	282	282
query78	10124	9970	9218	9218
query79	3482	805	598	598
query80	791	531	436	436
query81	495	284	238	238
query82	1140	151	120	120
query83	180	171	156	156
query84	284	92	70	70
query85	772	341	308	308
query86	374	336	290	290
query87	4422	4544	4484	4484
query88	4694	2188	2156	2156
query89	414	319	286	286
query90	1830	191	189	189
query91	132	136	105	105
query92	70	57	52	52
query93	3168	876	536	536
query94	769	393	298	298
query95	324	259	252	252
query96	495	641	290	290
query97	2845	2858	2775	2775
query98	228	208	202	202
query99	1468	1455	1370	1370
Total cold run time: 317174 ms
Total hot run time: 194665 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.25 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 88b1d1a6b7b28534fdc13fbb5b455af61a150101, data reload: false

query1	0.03	0.04	0.04
query2	0.07	0.04	0.03
query3	0.24	0.06	0.07
query4	1.62	0.10	0.10
query5	0.41	0.42	0.43
query6	1.16	0.66	0.65
query7	0.03	0.01	0.01
query8	0.04	0.03	0.04
query9	0.59	0.51	0.50
query10	0.57	0.56	0.56
query11	0.15	0.09	0.10
query12	0.14	0.12	0.11
query13	0.61	0.60	0.62
query14	2.71	2.71	2.74
query15	0.90	0.83	0.84
query16	0.38	0.38	0.39
query17	1.00	1.04	1.05
query18	0.23	0.20	0.20
query19	2.02	1.80	2.01
query20	0.02	0.02	0.01
query21	15.35	0.92	0.60
query22	0.74	0.76	0.68
query23	15.32	1.49	0.62
query24	3.21	0.98	1.25
query25	0.15	0.27	0.07
query26	0.29	0.15	0.14
query27	0.05	0.05	0.06
query28	13.60	1.54	1.04
query29	12.55	3.91	3.23
query30	0.25	0.09	0.06
query31	2.82	0.57	0.38
query32	3.23	0.55	0.45
query33	3.06	3.03	3.05
query34	16.95	5.12	4.44
query35	4.56	4.52	4.59
query36	0.67	0.50	0.47
query37	0.10	0.06	0.06
query38	0.04	0.04	0.04
query39	0.04	0.02	0.03
query40	0.17	0.14	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 106.23 s
Total hot run time: 31.25 s

@Jibing-Li
Copy link
Contributor Author

run external

@Jibing-Li Jibing-Li force-pushed the view branch 3 times, most recently from c3939b1 to af90bf0 Compare January 23, 2025 06:12
@Jibing-Li
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32460 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 38dafb193286db64748c6c419919cd59a93a9e36, data reload: false

------ Round 1 ----------------------------------
q1	17587	5511	5427	5427
q2	2056	307	167	167
q3	10412	1227	740	740
q4	10201	992	546	546
q5	7533	2437	2185	2185
q6	190	163	133	133
q7	919	743	610	610
q8	9246	1396	1211	1211
q9	5206	4813	4920	4813
q10	6836	2331	1883	1883
q11	494	273	255	255
q12	342	369	223	223
q13	17763	3668	3133	3133
q14	247	224	224	224
q15	514	488	477	477
q16	647	617	578	578
q17	583	874	336	336
q18	7119	6420	6421	6420
q19	2614	964	543	543
q20	313	314	188	188
q21	2878	2183	2046	2046
q22	359	336	322	322
Total cold run time: 104059 ms
Total hot run time: 32460 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6015	5468	5496	5468
q2	239	339	245	245
q3	2221	2685	2322	2322
q4	1452	1868	1431	1431
q5	4373	4717	4711	4711
q6	173	161	128	128
q7	2088	1971	1873	1873
q8	2640	2825	2723	2723
q9	7308	7254	7287	7254
q10	3035	3302	2755	2755
q11	567	512	484	484
q12	657	740	611	611
q13	3604	3936	3324	3324
q14	284	311	281	281
q15	512	488	473	473
q16	660	686	659	659
q17	1245	1761	1257	1257
q18	7771	7537	7505	7505
q19	814	1171	1079	1079
q20	2018	2005	1904	1904
q21	5982	5227	5126	5126
q22	615	622	574	574
Total cold run time: 54273 ms
Total hot run time: 52187 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192411 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 38dafb193286db64748c6c419919cd59a93a9e36, data reload: false

query1	1323	956	919	919
query2	6262	2121	2087	2087
query3	11088	4534	4483	4483
query4	61360	28763	23139	23139
query5	5529	592	462	462
query6	419	206	185	185
query7	5586	526	300	300
query8	344	255	231	231
query9	8403	2641	2633	2633
query10	480	313	255	255
query11	17597	15161	15513	15161
query12	160	112	117	112
query13	1476	573	434	434
query14	11420	7272	7342	7272
query15	208	206	190	190
query16	6882	661	470	470
query17	1101	724	578	578
query18	1261	365	312	312
query19	199	196	181	181
query20	121	113	119	113
query21	205	124	105	105
query22	4438	4702	4552	4552
query23	34284	33475	33591	33475
query24	5588	2469	2341	2341
query25	481	462	382	382
query26	644	272	161	161
query27	1778	483	334	334
query28	4083	2480	2439	2439
query29	530	552	424	424
query30	246	191	161	161
query31	943	887	836	836
query32	73	59	56	56
query33	417	373	310	310
query34	743	845	519	519
query35	838	874	756	756
query36	1029	1047	986	986
query37	119	107	77	77
query38	4249	4282	4291	4282
query39	1493	1468	1441	1441
query40	216	116	105	105
query41	52	52	49	49
query42	116	106	103	103
query43	526	529	501	501
query44	1336	839	833	833
query45	178	191	172	172
query46	903	1054	647	647
query47	1929	1919	1839	1839
query48	396	414	338	338
query49	742	500	401	401
query50	688	672	411	411
query51	4340	4300	4227	4227
query52	102	111	92	92
query53	232	264	202	202
query54	502	513	438	438
query55	89	83	83	83
query56	283	275	309	275
query57	1188	1188	1136	1136
query58	248	238	237	237
query59	3267	3206	3172	3172
query60	277	264	282	264
query61	115	109	112	109
query62	705	719	660	660
query63	218	191	184	184
query64	1277	1016	663	663
query65	3231	3124	3174	3124
query66	671	393	295	295
query67	15869	15566	15342	15342
query68	2681	778	559	559
query69	425	310	268	268
query70	1222	1109	1138	1109
query71	349	294	253	253
query72	6148	4066	4056	4056
query73	635	776	362	362
query74	9554	9166	8681	8681
query75	3156	3132	2699	2699
query76	2105	1165	782	782
query77	431	354	274	274
query78	10099	9972	9311	9311
query79	3574	810	589	589
query80	1720	539	440	440
query81	537	283	245	245
query82	429	155	136	136
query83	266	172	154	154
query84	292	104	80	80
query85	792	369	306	306
query86	458	313	282	282
query87	4366	4425	4610	4425
query88	5682	2180	2133	2133
query89	395	324	292	292
query90	1700	192	193	192
query91	130	134	107	107
query92	62	60	52	52
query93	2822	848	530	530
query94	747	412	305	305
query95	349	270	257	257
query96	499	616	296	296
query97	2771	2878	2742	2742
query98	240	205	196	196
query99	1292	1358	1242	1242
Total cold run time: 309024 ms
Total hot run time: 192411 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.42 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 38dafb193286db64748c6c419919cd59a93a9e36, data reload: false

query1	0.03	0.03	0.04
query2	0.08	0.03	0.03
query3	0.23	0.07	0.06
query4	1.62	0.10	0.10
query5	0.42	0.41	0.40
query6	1.14	0.65	0.65
query7	0.03	0.02	0.02
query8	0.04	0.03	0.03
query9	0.59	0.50	0.50
query10	0.54	0.57	0.55
query11	0.15	0.10	0.11
query12	0.14	0.11	0.11
query13	0.61	0.60	0.60
query14	2.80	2.72	2.75
query15	0.90	0.84	0.83
query16	0.39	0.38	0.38
query17	1.05	1.06	1.05
query18	0.23	0.21	0.21
query19	1.95	1.86	1.95
query20	0.01	0.01	0.01
query21	15.38	0.95	0.59
query22	0.76	0.73	0.89
query23	15.16	1.41	0.64
query24	2.93	0.97	0.43
query25	0.26	0.18	0.13
query26	0.26	0.15	0.14
query27	0.08	0.05	0.06
query28	13.45	1.03	0.43
query29	12.63	3.91	3.30
query30	0.24	0.10	0.06
query31	2.84	0.60	0.40
query32	3.23	0.55	0.47
query33	2.96	2.97	3.10
query34	16.47	5.11	4.49
query35	4.56	4.58	4.56
query36	0.64	0.49	0.48
query37	0.10	0.06	0.06
query38	0.04	0.04	0.04
query39	0.04	0.02	0.02
query40	0.17	0.13	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.03
query43	0.03	0.02	0.02
Total cold run time: 105.3 s
Total hot run time: 30.42 s

@Jibing-Li
Copy link
Contributor Author

run p0

@Jibing-Li
Copy link
Contributor Author

run cloud_p0

@Jibing-Li
Copy link
Contributor Author

run p0

1 similar comment
@Jibing-Li
Copy link
Contributor Author

run p0

@Jibing-Li
Copy link
Contributor Author

run cloud_p0

@Jibing-Li
Copy link
Contributor Author

run p0

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@Jibing-Li
Copy link
Contributor Author

run p0

@Jibing-Li
Copy link
Contributor Author

run cloud_p0

1 similar comment
@Jibing-Li
Copy link
Contributor Author

run cloud_p0

morningman
morningman approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morrySnow morrySnow merged commit d1ff166 into apache:master Jan 24, 2025
25 of 26 checks passed
@Jibing-Li Jibing-Li deleted the view branch January 24, 2025 10:29
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
@Jibing-Li @lzyy2024
[feature](view)Support modify view comment (apache#46910)
f2095bf 
### What problem does this PR solve?

Support modify view comment:


ALTER VIEW
[db_name.]view_name
MODIFY COMMENT "new comment"


### Release note

Support modify view comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morningman morningman morningman approved these changes

@morrySnow morrySnow morrySnow approved these changes

@dataroaring dataroaring Awaiting requested review from dataroaring dataroaring is a code owner

@CalvinKirs CalvinKirs Awaiting requested review from CalvinKirs CalvinKirs is a code owner

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.1.x reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jibing-Li @hello-stephen @doris-robot @morningman @morrySnow