Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opt](oceanbase docker)Use LTS docker image and print unhealthy docker logs #46647

Merged
merged 3 commits into from
Jan 9, 2025
Merged

[opt](oceanbase docker)Use LTS docker image and print unhealthy docker logs #46647

merged 3 commits into from
Jan 9, 2025

Conversation

Thearas
Copy link
Contributor

@Thearas Thearas commented Jan 8, 2025 •
edited
Loading

What problem does this PR solve?

Problem Summary:
Oceanbase container sometimes start failed.
image

We do two things:

  1. Print last 100 lines docker logs of unhealthy container for debugging
  2. Upgrade Oceanbase docker image to the newest 4.2.1-lts, since it is 7 months newer than 4.2.1, more stable

Release note

None

Check List (For Author)

  • Test
    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

Test detail:

./run-thirdparties-docker.sh -c oceanbase

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
[opt](oceanbase docker)Use LTS docker image and print unhealthy docke…
2e6d7de 
…r logs

Change-Id: I504fae1b944671055f65d9405df6a91f6f61ebf6
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

morningman
morningman previously approved these changes Jan 8, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jan 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

PR approved by anyone and no changes requested.

@morningman
Copy link
Contributor

run buildall

@Thearas
only print the latest unhealthy container logs
0882779 
Change-Id: I22b03373782ba3d25a43480f164f1e5596704013
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jan 9, 2025
@Thearas
Copy link
Contributor Author

Thearas commented Jan 9, 2025

run buildall

@Thearas
fix oceanbase case
2df1f30 
Change-Id: Ib8f66d825c587ea11faf244a38d307a2320e49a9
@Thearas
Copy link
Contributor Author

Thearas commented Jan 9, 2025

run buildall

@Thearas
Copy link
Contributor Author

Thearas commented Jan 9, 2025

run p0

zgxme
zgxme approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@zgxme zgxme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hello-stephen
hello-stephen approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@hello-stephen hello-stephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

PR approved by at least one committer and no changes requested.

@hello-stephen hello-stephen merged commit b7f1a41 into apache:master Jan 9, 2025
25 of 26 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 9, 2025
@Thearas
[opt](oceanbase docker)Use LTS docker image and print unhealthy docke…
720fada 
…r logs (#46647)

### What problem does this PR solve?

Problem Summary:
Oceanbase container sometimes start failed.
<img width="653" alt="image"
src="https://github.com/user-attachments/assets/d95c66cf-7e04-4179-a565-9b9dd8b87128"
/>

We do two things:
1. Print last 100 lines docker logs of unhealthy container for debugging
2. Upgrade Oceanbase docker image to the newest `4.2.1-lts`, since it is
7 months newer than `4.2.1`, more stable
@github-actions github-actions bot mentioned this pull request Jan 9, 2025
Merged
@Thearas Thearas deleted the opt-oceanbase-docker branch January 9, 2025 20:12
dataroaring pushed a commit that referenced this pull request Jan 17, 2025
@github-actions @Thearas
branch-3.0: [opt](oceanbase docker)Use LTS docker image and print unh…
63f0c0d 
…ealthy docker logs #46647 (#46711)

Cherry-picked from #46647

Co-authored-by: Thearas <gaozifeng@selectdb.com>
github-actions bot pushed a commit that referenced this pull request Jan 23, 2025
@Thearas
[opt](oceanbase docker)Use LTS docker image and print unhealthy docke…
911f478 
…r logs (#46647)

### What problem does this PR solve?

Problem Summary:
Oceanbase container sometimes start failed.
<img width="653" alt="image"
src="https://github.com/user-attachments/assets/d95c66cf-7e04-4179-a565-9b9dd8b87128"
/>

We do two things:
1. Print last 100 lines docker logs of unhealthy container for debugging
2. Upgrade Oceanbase docker image to the newest `4.2.1-lts`, since it is
7 months newer than `4.2.1`, more stable
@github-actions github-actions bot mentioned this pull request Jan 23, 2025
Closed
hello-stephen pushed a commit that referenced this pull request Jan 24, 2025
@Thearas
[opt](oceanbase docker)Use LTS docker image and print unhealthy docke…
3aad9e5 
…r logs (#46647) (#47349)

### What problem does this PR solve?

Problem Summary:
Oceanbase container sometimes start failed.
<img width="653" alt="image"

src="https://github.com/user-attachments/assets/d95c66cf-7e04-4179-a565-9b9dd8b87128"
/>

We do two things:
1. Print last 100 lines docker logs of unhealthy container for debugging
2. Upgrade Oceanbase docker image to the newest `4.2.1-lts`, since it is
7 months newer than `4.2.1`, more stable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hello-stephen hello-stephen hello-stephen approved these changes

@zgxme zgxme zgxme approved these changes

@morningman morningman morningman left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.9-merged dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Thearas @hello-stephen @morningman @zgxme @dataroaring