Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](regression) unstable case: partition_key_minmax #46597

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

englefly
Copy link
Contributor

@englefly englefly commented Jan 8, 2025

What problem does this PR solve?

root cause:
by default partition column stats analyze is disabled.
but in case partition_col_stats, it is turned on.

  1. make partition_key_minmax support partition column stats
  2. set nonConcurrent for partition_col_stats

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@englefly
Copy link
Contributor Author

englefly commented Jan 8, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

PR approved by anyone and no changes requested.

@englefly
Copy link
Contributor Author

englefly commented Jan 8, 2025

run p0

@englefly
Copy link
Contributor Author

englefly commented Jan 8, 2025

run cloud_p0

@englefly englefly merged commit 0d784c0 into apache:master Jan 9, 2025
26 of 27 checks passed
@englefly englefly deleted the min-max-case branch January 9, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants