Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug](explain) fix wrong display of SortAlgorithm on explain #46559

Merged
merged 2 commits into from
Jan 9, 2025
Merged

[Bug](explain) fix wrong display of SortAlgorithm on explain #46559

merged 2 commits into from
Jan 9, 2025

Conversation

BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Jan 7, 2025 •
edited
Loading

What problem does this PR solve?

fix wrong display of SortAlgorithm on explain

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

zclllyybb
zclllyybb approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

PR approved by anyone and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 9, 2025
@BiteTheDDDDt BiteTheDDDDt merged commit c50bd33 into apache:master Jan 9, 2025
24 of 26 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 14, 2025
@BiteTheDDDDt
[Bug](explain) fix wrong display of SortAlgorithm on explain (#46559)
3b3e8e9 
### What problem does this PR solve?
 fix wrong display of SortAlgorithm on explain
@github-actions github-actions bot mentioned this pull request Jan 14, 2025
Merged
BiteTheDDDDt added a commit that referenced this pull request Jan 14, 2025
@github-actions @BiteTheDDDDt
branch-3.0: [Bug](explain) fix wrong display of SortAlgorithm on expl…
37e5ce3 
…ain #46559 (#46979)

Cherry-picked from #46559

Co-authored-by: Pxl <xl@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zclllyybb zclllyybb zclllyybb approved these changes

@zhangstar333 zhangstar333 zhangstar333 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BiteTheDDDDt @hello-stephen @zclllyybb @zhangstar333 @wm1581066