Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](suites) Fix atomic restore alter suite with master_sql #46550

Merged
merged 3 commits into from
Jan 8, 2025
Merged

[fix](suites) Fix atomic restore alter suite with master_sql #46550

merged 3 commits into from
Jan 8, 2025

Conversation

w41ter
Copy link
Contributor

@w41ter w41ter commented Jan 7, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Add a helper master_sql, to connect to FE master and execute sql.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

shuke987
shuke987 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@shuke987 shuke987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

PR approved by anyone and no changes requested.

@w41ter
Copy link
Contributor Author

w41ter commented Jan 7, 2025

run buildall

dataroaring
dataroaring approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

PR approved by at least one committer and no changes requested.

@w41ter w41ter force-pushed the fix_atomic_restore_alter_case branch from 0b1a222 to 431b425 Compare January 8, 2025 03:04
@w41ter
Copy link
Contributor Author

w41ter commented Jan 8, 2025

run buildall

dataroaring
dataroaring approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit f7560a6 into apache:master Jan 8, 2025
23 of 24 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 8, 2025
@w41ter
[fix](suites) Fix atomic restore alter suite with master_sql (#46550)
30d5e33 
Add a helper `master_sql`, to connect to FE master and execute sql.
@github-actions github-actions bot mentioned this pull request Jan 8, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jan 8, 2025
@w41ter
[fix](suites) Fix atomic restore alter suite with master_sql (#46550)
de3d7a8 
Add a helper `master_sql`, to connect to FE master and execute sql.
@github-actions github-actions bot mentioned this pull request Jan 8, 2025
Merged
yiguolei pushed a commit that referenced this pull request Jan 9, 2025
@github-actions @w41ter
branch-2.1: [fix](suites) Fix atomic restore alter suite with master_…
84ea1ee 
…sql #46550 (#46653)

Cherry-picked from #46550

Co-authored-by: walter <maochuan@selectdb.com>
@w41ter w41ter deleted the fix_atomic_restore_alter_case branch January 9, 2025 02:54
w41ter added a commit that referenced this pull request Jan 9, 2025
@github-actions @w41ter
branch-3.0: [fix](suites) Fix atomic restore alter suite with master_…
5afdf61 
…sql #46550 (#46652)

Cherry-picked from #46550

Co-authored-by: walter <maochuan@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuke987 shuke987 shuke987 approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@w41ter @hello-stephen @shuke987 @dataroaring @yiguolei