[opt](nereids) compare literal not convert to legacy literal and fix ip literal compareTo always equals 0 #46482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
1 similar comment
|
run buildall |
16 tasks
TPC-H: Total hot run time: 33001 ms |
TPC-DS: Total hot run time: 196459 ms |
ClickBench: Total hot run time: 31.42 s |
|
run buildall |
2 similar comments
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 32945 ms |
TPC-DS: Total hot run time: 190010 ms |
ClickBench: Total hot run time: 31.42 s |
|
run buildall |
TPC-H: Total hot run time: 32593 ms |
TPC-DS: Total hot run time: 189945 ms |
ClickBench: Total hot run time: 30.98 s |
|
run buildall |
2 similar comments
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 32749 ms |
TPC-DS: Total hot run time: 194359 ms |
ClickBench: Total hot run time: 31.87 s |
|
run buildall |
yujun777
changed the title
TPC-H: Total hot run time: 32736 ms |
TPC-DS: Total hot run time: 194436 ms |
ClickBench: Total hot run time: 32.08 s |
|
run external |
924060929
reviewed
Jan 15, 2025
Comment on lines
270
to
275
| try { | ||
| return BooleanLiteral.of(((ComparableLiteral) equalTo.left()) | ||
| .compareTo((ComparableLiteral) equalTo.right()) == 0); | ||
| } catch (Exception e) { | ||
| // left and right maybe not comparable | ||
| return BooleanLiteral.of(equalTo.left().equals(equalTo.right())); | ||
| } |
There was a problem hiding this comment.
add this to try best to avoid throw exception because throw exception are too slow, similar modifications also need to be made in this way
if (equalTo.left() instanceof ComparableLiteral && equalsTo.right() instanceof ComparableLiteral) {
try {
return BooleanLiteral.of(((ComparableLiteral) equalTo.left())
.compareTo((ComparableLiteral) equalTo.right()) == 0);
} catch (Exception e) {
return BooleanLiteral.of(equalTo.left().equals(equalTo.right()));
}
} else {
return BooleanLiteral.of(equalTo.left().equals(equalTo.right()));
}There was a problem hiding this comment.
add this to try best to avoid throw exception because throw exception are too slow, similar modifications also need to be made in this way
if (equalTo.left() instanceof ComparableLiteral && equalsTo.right() instanceof ComparableLiteral) { try { return BooleanLiteral.of(((ComparableLiteral) equalTo.left()) .compareTo((ComparableLiteral) equalTo.right()) == 0); } catch (Exception e) { return BooleanLiteral.of(equalTo.left().equals(equalTo.right())); } } else { return BooleanLiteral.of(equalTo.left().equals(equalTo.right())); }
fix
| thisBytes = getStringValue().getBytes("UTF-8"); | ||
| otherBytes = ((Literal) other).getStringValue().getBytes("UTF-8"); | ||
| } catch (UnsupportedEncodingException e) { | ||
| Preconditions.checkState(false); |
There was a problem hiding this comment.
do not eat the exception. new AnalysisException and wrap UnsupportedEncodingException and then throw it
There was a problem hiding this comment.
do not eat the exception. new AnalysisException and wrap UnsupportedEncodingException and then throw it
fix
|
run buildall |
TPC-H: Total hot run time: 33447 ms |
TPC-DS: Total hot run time: 188563 ms |
ClickBench: Total hot run time: 31.32 s |
|
run cloud_p0 |
|
run p0 |
1 similar comment
|
run p0 |
924060929
approved these changes
Jan 23, 2025
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
morrySnow
force-pushed
the
opt-to-legacy-literal-2
branch
from
c97b0f5 to
2dd034b
Compare
|
run buildall |
morrySnow
approved these changes
Feb 5, 2025
TPC-H: Total hot run time: 32246 ms |
TPC-DS: Total hot run time: 184776 ms |
ClickBench: Total hot run time: 30.64 s |
|
run cloud_p0 |
2 similar comments
|
run cloud_p0 |
|
run cloud_p0 |
morningman
approved these changes
Feb 7, 2025
lzyy2024
pushed a commit
to lzyy2024/doris
that referenced
this pull request
Feb 21, 2025
…ip literal compareTo always equals 0 (apache#46482) ### What problem does this PR solve? Problem Summary: as apache#45181 mention, when sorting literals, toLegacyLiteral may cost a lot of time, so compare literal don't use toLegacyLiteral any more. legacy literal may have an unknown behaviour comparing two values with different data type. for neredis literals, different data type value compare will throw an exception, it support valid compare with data types: 1. boolean vs boolean; 2. numeric vs numeric; 3. string like vs string like; 4. date like vs date like; 5. ipv4 vs ipv4; 6. ipv6 vs ipv6; 7. array vs array; 8. above data types vs null and max; what's more, this pr also: 1. nereids literal remove implements Comparable<Literal>; 2. add a new interface ComparableLiteral, and the above type literals will implement it; 3. fix ipv4 / ipv6 / map / struct compareTo always return 0;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
as #45181 mention, when sorting literals, toLegacyLiteral may cost a lot of time, so compare literal don't use toLegacyLiteral any more.
legacy literal may have an unknown behaviour comparing two values with different data type.
for neredis literals, different data type value compare will throw an exception, it support valid compare with data types:
what's more, this pr also:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)