Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](cross join) fix memory usage counter #46152

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

jacktengg
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 30, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@jacktengg
Copy link
Contributor Author

run buildall

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 30, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 32785 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 63ace1782a94f3b3c792615e106f14d6265c6555, data reload: false

------ Round 1 ----------------------------------
q1	17584	6142	6632	6142
q2	2052	302	169	169
q3	10547	1249	771	771
q4	10302	866	436	436
q5	9153	2217	1971	1971
q6	213	181	149	149
q7	901	775	618	618
q8	9243	1354	1170	1170
q9	5310	4858	4959	4858
q10	6796	2334	1845	1845
q11	490	281	276	276
q12	355	362	222	222
q13	17798	3619	3010	3010
q14	228	221	208	208
q15	577	510	497	497
q16	616	619	604	604
q17	584	863	337	337
q18	6771	6413	6461	6413
q19	2346	990	589	589
q20	304	321	182	182
q21	3130	2231	1999	1999
q22	373	343	319	319
Total cold run time: 105673 ms
Total hot run time: 32785 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6432	6287	6261	6261
q2	243	329	228	228
q3	2250	2640	2309	2309
q4	1416	1810	1355	1355
q5	4369	4755	4878	4755
q6	182	175	146	146
q7	2079	1944	1837	1837
q8	2613	2787	2739	2739
q9	7226	7297	7327	7297
q10	3112	3343	2763	2763
q11	584	522	513	513
q12	676	760	600	600
q13	3446	3804	3071	3071
q14	279	316	307	307
q15	566	514	504	504
q16	645	703	659	659
q17	1230	1726	1234	1234
q18	7589	7558	7430	7430
q19	867	1181	1155	1155
q20	2034	2077	1891	1891
q21	5617	5266	5055	5055
q22	645	627	639	627
Total cold run time: 54100 ms
Total hot run time: 52736 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.90% (10120/26016)
Line Coverage: 29.90% (85528/286092)
Region Coverage: 29.02% (43714/150611)
Branch Coverage: 25.55% (22297/87256)
Coverage Report: http://coverage.selectdb-in.cc/coverage/63ace1782a94f3b3c792615e106f14d6265c6555_63ace1782a94f3b3c792615e106f14d6265c6555/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 196870 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 63ace1782a94f3b3c792615e106f14d6265c6555, data reload: false

query1	1309	947	994	947
query2	6523	2338	2339	2338
query3	10937	4562	4540	4540
query4	33193	24035	23496	23496
query5	3883	635	460	460
query6	258	196	177	177
query7	3980	478	296	296
query8	297	242	224	224
query9	9494	2749	2735	2735
query10	429	334	263	263
query11	17895	15295	15192	15192
query12	155	104	101	101
query13	1563	537	420	420
query14	10382	7555	7071	7071
query15	259	227	193	193
query16	8026	606	463	463
query17	1566	770	615	615
query18	2084	422	333	333
query19	220	196	181	181
query20	131	122	113	113
query21	212	127	111	111
query22	4665	4508	4361	4361
query23	34386	33568	33468	33468
query24	6819	2395	2350	2350
query25	474	461	386	386
query26	1017	279	153	153
query27	2092	457	334	334
query28	5638	2559	2484	2484
query29	650	562	430	430
query30	219	199	151	151
query31	1001	951	886	886
query32	79	69	56	56
query33	477	354	308	308
query34	769	863	535	535
query35	825	835	759	759
query36	1066	1071	994	994
query37	116	101	83	83
query38	4264	4430	4239	4239
query39	1532	1469	1423	1423
query40	209	113	99	99
query41	46	42	45	42
query42	124	109	104	104
query43	510	528	493	493
query44	1348	826	832	826
query45	187	180	179	179
query46	887	1094	664	664
query47	2002	1969	1938	1938
query48	396	421	330	330
query49	716	496	385	385
query50	632	671	403	403
query51	7373	7230	7301	7230
query52	104	99	92	92
query53	238	255	192	192
query54	490	517	415	415
query55	86	81	84	81
query56	269	273	235	235
query57	1263	1233	1168	1168
query58	246	236	221	221
query59	3138	3252	3147	3147
query60	277	267	242	242
query61	106	102	108	102
query62	858	800	758	758
query63	228	194	207	194
query64	3384	1031	676	676
query65	3381	3301	3290	3290
query66	763	408	313	313
query67	16481	15897	15689	15689
query68	9807	769	516	516
query69	489	285	252	252
query70	1233	1156	1142	1142
query71	439	300	255	255
query72	5863	3988	3860	3860
query73	1339	763	364	364
query74	10066	8991	9069	8991
query75	4514	3120	2647	2647
query76	5546	1231	769	769
query77	990	357	312	312
query78	10167	10276	9373	9373
query79	2586	905	611	611
query80	703	505	439	439
query81	474	279	235	235
query82	334	154	126	126
query83	193	159	150	150
query84	282	99	69	69
query85	732	442	300	300
query86	333	310	294	294
query87	4667	4468	4399	4399
query88	3345	2265	2238	2238
query89	411	322	294	294
query90	1954	192	189	189
query91	137	133	102	102
query92	68	56	52	52
query93	1436	869	543	543
query94	656	377	288	288
query95	353	268	253	253
query96	549	611	279	279
query97	2734	2830	2691	2691
query98	219	197	194	194
query99	1657	1541	1466	1466
Total cold run time: 298903 ms
Total hot run time: 196870 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.14 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 63ace1782a94f3b3c792615e106f14d6265c6555, data reload: false

query1	0.04	0.04	0.04
query2	0.06	0.04	0.03
query3	0.24	0.07	0.07
query4	1.62	0.10	0.10
query5	0.41	0.43	0.41
query6	1.15	0.65	0.64
query7	0.03	0.02	0.02
query8	0.04	0.02	0.04
query9	0.59	0.50	0.53
query10	0.56	0.54	0.54
query11	0.14	0.10	0.11
query12	0.14	0.11	0.11
query13	0.61	0.61	0.60
query14	2.85	2.72	2.80
query15	0.90	0.83	0.83
query16	0.38	0.38	0.39
query17	1.06	1.05	0.99
query18	0.22	0.21	0.21
query19	1.98	1.87	1.94
query20	0.01	0.01	0.02
query21	15.39	0.91	0.57
query22	0.76	0.87	0.73
query23	15.17	1.37	0.59
query24	2.60	1.71	1.73
query25	0.11	0.13	0.05
query26	0.33	0.15	0.14
query27	0.05	0.06	0.05
query28	14.63	1.47	1.05
query29	12.62	4.01	3.31
query30	0.24	0.09	0.07
query31	2.82	0.62	0.39
query32	3.23	0.55	0.47
query33	3.17	3.13	3.09
query34	16.72	5.13	4.49
query35	4.47	4.45	4.47
query36	0.66	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.17	0.14	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.5 s
Total hot run time: 32.14 s

@yiguolei yiguolei merged commit 752bf93 into apache:master Jan 1, 2025
24 of 26 checks passed
jacktengg added a commit to jacktengg/incubator-doris that referenced this pull request Jan 3, 2025
jacktengg added a commit to jacktengg/incubator-doris that referenced this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants