-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore](version) Show binary version in metrics: fe be ms #45490
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
clang-tidy review says "All clean, LGTM! 👍" |
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TeamCity be ut coverage result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, better add a regression test
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
OK, I will post another PR to add a regression test |
### What problem does this PR solve? Related PR: #45490 Problem Summary: ```shell In gensrc/script/gen_build_version.sh line 38: if [[ ${build_version_hotfix} > 0 ]]; then ^-- SC2071 (error): > is for string comparisons. Use -gt instead. In gensrc/script/gen_build_version.sh line 228: if [[ ${build_version_hotfix} > 0 ]]; then ^-- SC2071 (error): > is for string comparisons. Use -gt instead. ```
before ``` root@af0e5d234e63:~# curl 127.0.0.1:8030/metrics | grep doris_fe_version root@af0e5d234e63:~# curl 127.0.0.1:8060/brpc_metrics | grep doris_be_version root@af0e5d234e63:~# curl 127.0.0.1:5000/brpc_metrics | grep doris_cloud_version ``` after ``` [root@dbb7fecb3b61 output]# curl 127.0.0.1:8030/metrics | grep doris_fe_version # TYPE doris_fe_version gauge doris_fe_version 30004 [root@dbb7fecb3b61 output]# curl 127.0.0.1:8060/brpc_metrics | grep doris_be_version # TYPE doris_be_version gauge doris_be_version 30004 [root@dbb7fecb3b61 output]# curl 127.0.0.1:5000/brpc_metrics | grep doris_cloud_version # TYPE doris_cloud_version gauge doris_cloud_version 30004 ``` Co-authored-by: Gavin Chou <gavineaglechou@gmail.com> (cherry picked from commit 038dd93)
…#45490) (#45841) before ``` root@af0e5d234e63:~# curl 127.0.0.1:8030/metrics | grep doris_fe_version root@af0e5d234e63:~# curl 127.0.0.1:8060/brpc_metrics | grep doris_be_version root@af0e5d234e63:~# curl 127.0.0.1:5000/brpc_metrics | grep doris_cloud_version ``` after ``` [root@dbb7fecb3b61 output]# curl 127.0.0.1:8030/metrics | grep doris_fe_version # TYPE doris_fe_version gauge doris_fe_version 30004 [root@dbb7fecb3b61 output]# curl 127.0.0.1:8060/brpc_metrics | grep doris_be_version # TYPE doris_be_version gauge doris_be_version 30004 [root@dbb7fecb3b61 output]# curl 127.0.0.1:5000/brpc_metrics | grep doris_cloud_version # TYPE doris_cloud_version gauge doris_cloud_version 30004 ```
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
pick from https://github.com/selectdb/selectdb-core/commit/1985902d
before
after
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)