Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](jdbc catalog) set enable_jdbc_cast_predicate_push_down default true #44548

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Nov 25, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #42102

Problem Summary:

We found that after disabling pushdown of predicates with implicit casts, some users experienced slower queries, so we temporarily changed this parameter back to the default behavior.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zy-kkk
Copy link
Member Author

zy-kkk commented Nov 25, 2024

run buildall

@zy-kkk
Copy link
Member Author

zy-kkk commented Nov 26, 2024

run buildall

@morningman morningman closed this Nov 26, 2024
@morningman morningman reopened this Nov 26, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Nov 28, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman merged commit 8492f02 into apache:master Nov 28, 2024
36 of 38 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 28, 2024
…t true (#44548)

### What problem does this PR solve?

Related PR: #42102

Problem Summary:

We found that after disabling pushdown of predicates with implicit
casts, some users experienced slower queries, so we temporarily changed
this parameter back to the default behavior.
github-actions bot pushed a commit that referenced this pull request Nov 28, 2024
…t true (#44548)

### What problem does this PR solve?

Related PR: #42102

Problem Summary:

We found that after disabling pushdown of predicates with implicit
casts, some users experienced slower queries, so we temporarily changed
this parameter back to the default behavior.
yiguolei pushed a commit that referenced this pull request Nov 29, 2024
…t true (#44548)

### What problem does this PR solve?

Related PR: #42102

Problem Summary:

We found that after disabling pushdown of predicates with implicit
casts, some users experienced slower queries, so we temporarily changed
this parameter back to the default behavior.
yiguolei pushed a commit that referenced this pull request Dec 1, 2024
…t true (#44548)

### What problem does this PR solve?

Related PR: #42102

Problem Summary:

We found that after disabling pushdown of predicates with implicit
casts, some users experienced slower queries, so we temporarily changed
this parameter back to the default behavior.
yiguolei pushed a commit that referenced this pull request Dec 2, 2024
…down` default true #44548 (#44760)

Cherry-picked from #44548

Co-authored-by: zy-kkk <zhongyongkang@selectdb.com>
dataroaring pushed a commit that referenced this pull request Dec 6, 2024
…down` default true #44548 (#44759)

Cherry-picked from #44548

Co-authored-by: zy-kkk <zhongyongkang@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants