Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](Nerieds) fix Illegal join with wrong distribution STORAGE_BUCKETED #44257

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

924060929
Copy link
Contributor

What problem does this PR solve?

fix

java.lang.IllegalStateException: exceptions : exception : errCode = 2, detailMessage = Illegal join with wrong distribution, left: STORAGE_BUCKETED, right: STORAGE_BUCKETED

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@924060929
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 45317 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6a6c2d83735d5d2ec3d805d3e0a5b6e89c5544e0, data reload: false

------ Round 1 ----------------------------------
q1	17602	7612	7374	7374
q2	2245	1164	1159	1159
q3	10056	1152	1104	1104
q4	10309	749	784	749
q5	7566	2773	2760	2760
q6	243	154	151	151
q7	977	636	600	600
q8	9358	2372	2358	2358
q9	6708	6435	6408	6408
q10	7024	2304	2299	2299
q11	473	258	262	258
q12	422	232	217	217
q13	17772	3049	3068	3049
q14	258	215	219	215
q15	573	517	525	517
q16	681	602	604	602
q17	1016	580	502	502
q18	7445	6767	6764	6764
q19	1329	965	1075	965
q20	2889	2708	2703	2703
q21	4010	3354	3222	3222
q22	1378	1356	1341	1341
Total cold run time: 110334 ms
Total hot run time: 45317 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7319	7271	7269	7269
q2	330	227	229	227
q3	2983	2887	2795	2795
q4	2009	1696	1732	1696
q5	5418	5466	5459	5459
q6	220	140	139	139
q7	2146	1703	1712	1703
q8	3308	3411	3432	3411
q9	8618	8513	8594	8513
q10	3539	3451	3450	3450
q11	590	504	493	493
q12	795	582	598	582
q13	11580	3040	3011	3011
q14	294	252	266	252
q15	568	514	498	498
q16	689	639	623	623
q17	1962	1613	1558	1558
q18	7887	7562	7581	7562
q19	1701	1601	1453	1453
q20	2068	1827	1812	1812
q21	5553	5302	5291	5291
q22	622	552	589	552
Total cold run time: 70199 ms
Total hot run time: 58349 ms

@924060929
Copy link
Contributor Author

run performance

@doris-robot
Copy link

TPC-H: Total hot run time: 45474 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6a6c2d83735d5d2ec3d805d3e0a5b6e89c5544e0, data reload: false

------ Round 1 ----------------------------------
q1	17715	7718	7370	7370
q2	2276	1177	1161	1161
q3	10032	1163	1138	1138
q4	10315	714	734	714
q5	7614	3001	2659	2659
q6	247	149	151	149
q7	974	637	630	630
q8	9365	2373	2361	2361
q9	6660	6437	6485	6437
q10	7036	2312	2363	2312
q11	466	259	250	250
q12	417	222	217	217
q13	17794	3048	3106	3048
q14	244	219	215	215
q15	581	545	527	527
q16	663	584	585	584
q17	984	560	632	560
q18	7547	6750	6931	6750
q19	1339	1057	1011	1011
q20	2940	2708	2726	2708
q21	4092	3400	3347	3347
q22	1391	1373	1326	1326
Total cold run time: 110692 ms
Total hot run time: 45474 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7348	7374	7462	7374
q2	343	244	240	240
q3	3103	3092	3009	3009
q4	2126	1856	1885	1856
q5	5674	5725	5800	5725
q6	224	138	135	135
q7	2232	1879	1834	1834
q8	3327	3573	3548	3548
q9	8971	8922	8943	8922
q10	3649	3659	3533	3533
q11	608	525	525	525
q12	812	648	648	648
q13	12192	3342	3327	3327
q14	312	264	272	264
q15	587	524	536	524
q16	701	647	656	647
q17	1863	1640	1614	1614
q18	8474	7754	7723	7723
q19	1770	1592	1554	1554
q20	2117	1924	1884	1884
q21	5706	5457	5452	5452
q22	630	592	559	559
Total cold run time: 72769 ms
Total hot run time: 60897 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.8 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6a6c2d83735d5d2ec3d805d3e0a5b6e89c5544e0, data reload: false

query1	0.03	0.05	0.03
query2	0.06	0.03	0.04
query3	0.23	0.07	0.06
query4	1.64	0.11	0.11
query5	0.42	0.45	0.40
query6	1.15	0.65	0.65
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.60	0.50	0.48
query10	0.56	0.56	0.56
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.61	0.60
query14	2.71	2.71	2.69
query15	0.91	0.83	0.82
query16	0.39	0.38	0.37
query17	1.05	1.05	1.04
query18	0.21	0.21	0.20
query19	1.94	1.87	1.97
query20	0.02	0.02	0.02
query21	15.35	0.58	0.56
query22	3.10	1.93	1.77
query23	16.86	1.08	0.81
query24	2.84	1.16	2.19
query25	0.16	0.16	0.11
query26	0.67	0.14	0.13
query27	0.06	0.04	0.04
query28	9.88	1.10	1.07
query29	12.59	3.29	3.26
query30	0.24	0.06	0.06
query31	2.83	0.39	0.39
query32	3.27	0.47	0.48
query33	2.99	3.04	3.06
query34	16.96	4.45	4.49
query35	4.56	4.53	4.51
query36	0.65	0.48	0.48
query37	0.09	0.06	0.07
query38	0.05	0.03	0.04
query39	0.03	0.02	0.03
query40	0.16	0.13	0.12
query41	0.07	0.03	0.02
query42	0.04	0.02	0.03
query43	0.04	0.04	0.03
Total cold run time: 106.36 s
Total hot run time: 32.8 s

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 19, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

@924060929 924060929 merged commit 070489c into apache:master Nov 20, 2024
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. not-merge/3.0 reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants